Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1852813002: Improve clarity of the Physical Web opt-in notification message (Closed)

Created:
4 years, 8 months ago by mattreynolds
Modified:
4 years, 8 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve clarity of the Physical Web opt-in notification message Previously: "Physical Web pages are nearby / Use Chrome to browse them" Now: "Web pages are nearby / View them in Chrome" This is a strings-only change. BUG=598106 Committed: https://crrev.com/97069b19e5cbd4594ff612e258c12d4bdddd06c0 Cr-Commit-Position: refs/heads/master@{#384735}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mattreynolds
Hi Tommy, PTAL. Once this is merged we're hoping to cherry-pick it for M51
4 years, 8 months ago (2016-04-01 19:33:10 UTC) #2
nyquist
lgtm
4 years, 8 months ago (2016-04-01 22:43:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852813002/1
4 years, 8 months ago (2016-04-01 22:51:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 23:58:42 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-02 00:01:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97069b19e5cbd4594ff612e258c12d4bdddd06c0
Cr-Commit-Position: refs/heads/master@{#384735}

Powered by Google App Engine
This is Rietveld 408576698