Reland of Gerrit git cl: implement git cl patch.

Reland of Gerrit git cl: implement git cl patch. (patchset #1 id:1 of https://codereview.chromium.org/1848393002/ )

Reason for revert:
nope, the windows breakage is due to apply_issue failing to connect to Rietveld.

Original issue's description:
> Revert of Gerrit git cl: implement git cl patch. (patchset #7 id:120001 of https://codereview.chromium.org/1852593002/ )
> 
> Reason for revert:
> just in case.
> 
> Original issue's description:
> > Gerrit git cl: implement git cl patch.
> > 
> > BUG=579182
> > 
> > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299644
> 
> TBR=andybons@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=579182
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299645

TBR=andybons@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=579182
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299647

[tandrii(chromium), 2016-04-01 19:27:22]

Created Reland of Gerrit git cl: implement git cl patch.

[commit-bot: I haz the power, 2016-04-01 19:27:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1852803002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1852803002/1

[commit-bot: I haz the power, 2016-04-01 19:27:31]

Description was changed from

==========
Reland of Gerrit git cl: implement git cl patch. (patchset #1 id:1 of
https://codereview.chromium.org/1848393002/ )

Reason for revert:
nope, the windows breakage is due to apply_issue failing to connect to Rietveld.

Original issue's description:
> Revert of Gerrit git cl: implement git cl patch. (patchset #7 id:120001 of
https://codereview.chromium.org/1852593002/ )
> 
> Reason for revert:
> just in case.
> 
> Original issue's description:
> > Gerrit git cl: implement git cl patch.
> > 
> > BUG=579182
> > 
> > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299644
> 
> TBR=andybons@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=579182
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299645

TBR=andybons@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=579182
==========

to

==========
Reland of Gerrit git cl: implement git cl patch. (patchset #1 id:1 of
https://codereview.chromium.org/1848393002/ )

Reason for revert:
nope, the windows breakage is due to apply_issue failing to connect to Rietveld.

Original issue's description:
> Revert of Gerrit git cl: implement git cl patch. (patchset #7 id:120001 of
https://codereview.chromium.org/1852593002/ )
> 
> Reason for revert:
> just in case.
> 
> Original issue's description:
> > Gerrit git cl: implement git cl patch.
> > 
> > BUG=579182
> > 
> > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299644
> 
> TBR=andybons@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=579182
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299645

TBR=andybons@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=579182

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299647
==========

[commit-bot: I haz the power, 2016-04-01 19:27:31]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299647

[servolk, 2016-04-06 22:14:16]

On 2016/04/01 19:27:31, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
> http://src.chromium.org/viewvc/chrome?view=rev&revision=299647

Hi,
I have noticed that 'git cl diff' has stopped working recently. I'm getting
this:
servolk@servolk:/media/ssd/chromium/src$ git cl diff
Traceback (most recent call last):
  File "/usr/local/google/home/servolk/depot_tools/git_cl.py", line 4626, in
<module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/google/home/servolk/depot_tools/git_cl.py", line 4608, in
main
    return dispatcher.execute(OptionParser(), argv)
  File "/usr/local/google/home/servolk/depot_tools/subcommand.py", line 252, in
execute
    return command(parser, args[1:])
  File "/usr/local/google/home/servolk/depot_tools/git_cl.py", line 4320, in
CMDdiff
    rtn = cl.CMDPatchIssue(issue, reject=False, nocommit=False, directory=None)
  File "/usr/local/google/home/servolk/depot_tools/git_cl.py", line 1300, in
CMDPatchIssue
    if issue_arg.isdigit():
AttributeError: 'int' object has no attribute 'isdigit'

Git blame led me to this CL, which added that "issue_arg.isdigit" call in
CMDPatchIssue.
Any ideas how to fix git cl diff?

[Bons, 2016-04-06 22:19:07]

On 2016/04/06 22:14:16, servolk wrote:
> On 2016/04/01 19:27:31, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> > http://src.chromium.org/viewvc/chrome?view=rev&revision=299647
> 
> Hi,
> I have noticed that 'git cl diff' has stopped working recently. I'm getting
> this:
> servolk@servolk:/media/ssd/chromium/src$ git cl diff
> Traceback (most recent call last):
>   File "/usr/local/google/home/servolk/depot_tools/git_cl.py", line 4626, in
> <module>
>     sys.exit(main(sys.argv[1:]))
>   File "/usr/local/google/home/servolk/depot_tools/git_cl.py", line 4608, in
> main
>     return dispatcher.execute(OptionParser(), argv)
>   File "/usr/local/google/home/servolk/depot_tools/subcommand.py", line 252,
in
> execute
>     return command(parser, args[1:])
>   File "/usr/local/google/home/servolk/depot_tools/git_cl.py", line 4320, in
> CMDdiff
>     rtn = cl.CMDPatchIssue(issue, reject=False, nocommit=False,
directory=None)
>   File "/usr/local/google/home/servolk/depot_tools/git_cl.py", line 1300, in
> CMDPatchIssue
>     if issue_arg.isdigit():
> AttributeError: 'int' object has no attribute 'isdigit'
> 
> Git blame led me to this CL, which added that "issue_arg.isdigit" call in
> CMDPatchIssue.
> Any ideas how to fix git cl diff?

Please file a bug, assign to tandrii@ and cc me. We will take a look.

[tandrii(chromium), 2016-04-07 09:18:13]

+servoik

Thanks for report! FIX is here  https://codereview.chromium.org/1871463003/