src/effects/SkDropShadowImageFilter.cpp - Issue 1852743002: Update SkBlurImageFilter to sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkDropShadowImageFilter.cpp

Issue 1852743002: Update SkBlurImageFilter to sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Update to ToT & address code review comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkDropShadowImageFilter.cpp

diff --git a/src/effects/SkDropShadowImageFilter.cpp b/src/effects/SkDropShadowImageFilter.cpp

index 331cfbd68bfe159993e62d120d071f858e64c5c4..9cacad5513956f35774460cdfe25f486c0632e3f 100644

--- a/src/effects/SkDropShadowImageFilter.cpp

+++ b/src/effects/SkDropShadowImageFilter.cpp

@@ -84,9 +84,8 @@ sk_sp<SkSpecialImage> SkDropShadowImageFilter::onFilterImage(SkSpecialImage* sou

sigma.fX = SkMaxScalar(0, sigma.fX);

sigma.fY = SkMaxScalar(0, sigma.fY);

- SkAutoTUnref<SkImageFilter> blurFilter(SkBlurImageFilter::Create(sigma.fX, sigma.fY));

SkPaint paint;

- paint.setImageFilter(blurFilter.get());

+ paint.setImageFilter(SkBlurImageFilter::Make(sigma.fX, sigma.fY, nullptr));

paint.setColorFilter(SkColorFilter::MakeModeFilter(fColor, SkXfermode::kSrcIn_Mode));

paint.setXfermodeMode(SkXfermode::kSrcOver_Mode);

« no previous file with comments | « src/effects/SkBlurImageFilter.cpp ('k') | src/utils/SkLua.cpp » ('j') | no next file with comments »