Subzero: Fix a cleanup error after the IceString removal CL.

src/IceTargetLoweringX8664.cpp

 //===- subzero/src/IceTargetLoweringX8664.cpp - x86-64 lowering -----------===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 388 matching lines @@
       // NeedLea below.)
       if (Shift == 0 && isAssignedToRspOrRbp(Index) && ZeroReg == RebasePtr) {
         ZeroReg = Index;
       } else {
         T = Index;
         Shift = Mem->getShift();
       }
     }
   }
 
-  // NeedsLea is a flags indicating whether Mem needs to be materialized to a
-  // GPR prior to being used. A LEA is needed if Mem.Offset is a constant
+  // NeedsLea is a flag indicating whether Mem needs to be materialized to a GPR
+  // prior to being used. A LEA is needed if Mem.Offset is a constant
   // relocatable, or if Mem.Offset is negative. In both these cases, the LEA is
   // needed to ensure the sandboxed memory operand will only use the lower
   // 32-bits of T+Offset.
   bool NeedsLea = false;
   if (Offset != nullptr) {
-    if (const auto *CR = llvm::dyn_cast<ConstantRelocatable>(Offset)) {
-      NeedsLea = CR->getOffset() < 0;
+    if (llvm::isa<ConstantRelocatable>(Offset)) {
+      NeedsLea = true;
     } else if (const auto *Imm = llvm::dyn_cast<ConstantInteger32>(Offset)) {
       NeedsLea = Imm->getValue() < 0;
     } else {
       llvm::report_fatal_error("Unexpected Offset type.");
     }
   }
 
   RegNumT RegNum, RegNum32;
   if (T != nullptr) {
     if (T->hasReg()) {
@@ skipping 382 matching lines @@
 #define X(tag, sizeLog2, align, elts, elty, str, rcstr)                        \
   static_assert(_table1_##tag == _table2_##tag,                                \
                 "Inconsistency between ICETYPEX8664_TABLE and ICETYPE_TABLE");
 ICETYPE_TABLE
 #undef X
 } // end of namespace dummy3
 } // end of anonymous namespace
 
 } // end of namespace X8664
 } // end of namespace Ice