Fix treatment of rest pattern in array destructuring.

Fix treatment of rest pattern in array destructuring.

When seeing a rest pattern, we used to get the remaining elements from the
iterator by calling %concat_iterable_to_array on it.  This was wrong because it
caused an observable [[Get]] for @@iterator (which the iterator may not even
provide).

This CL gets rid of the call to %concat_iterable_to_array and does the iteration
manually in a simple while-loop.  It also gets rid of %concat_iterable_to_array
itself because there aren't any other uses of it.

BUG=v8:4759
LOG=n
R=adamk@chromium.org

Committed: https://crrev.com/4edf16ddd97d8f23d35b57f46b30aada5e8e94a2
Cr-Commit-Position: refs/heads/master@{#35251}

[adamk, 2016-04-04 19:32:46]

lgtm with one suggested reorganization

https://codereview.chromium.org/1852703002/diff/1/src/parsing/pattern-rewrite...
File src/parsing/pattern-rewriter.cc (right):

https://codereview.chromium.org/1852703002/diff/1/src/parsing/pattern-rewrite...
src/parsing/pattern-rewriter.cc:584: Expression* result_value =
factory()->NewProperty(
Can you move this inside the AppendElement block below? Putting it outside the
block makes it look like it'll be reused, which would be bad if it happened.

https://codereview.chromium.org/1852703002/diff/1/src/parsing/pattern-rewrite...
src/parsing/pattern-rewriter.cc:589: // %AppendElement(array, #result_value);
When you do the above you can just make this "result.value" instead of
"#result_value".

[neis, 2016-04-05 08:31:07]

On 2016/04/04 19:32:46, adamk wrote:
> lgtm with one suggested reorganization
> 
>
https://codereview.chromium.org/1852703002/diff/1/src/parsing/pattern-rewrite...
> File src/parsing/pattern-rewriter.cc (right):
> 
>
https://codereview.chromium.org/1852703002/diff/1/src/parsing/pattern-rewrite...
> src/parsing/pattern-rewriter.cc:584: Expression* result_value =
> factory()->NewProperty(
> Can you move this inside the AppendElement block below? Putting it outside the
> block makes it look like it'll be reused, which would be bad if it happened.
> 
>
https://codereview.chromium.org/1852703002/diff/1/src/parsing/pattern-rewrite...
> src/parsing/pattern-rewriter.cc:589: // %AppendElement(array, #result_value);
> When you do the above you can just make this "result.value" instead of
> "#result_value".

done

[neis, 2016-04-05 08:31:18]

The CQ bit was checked by neis@chromium.org

[neis, 2016-04-05 08:31:18]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/1852703002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-04-05 08:31:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1852703002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1852703002/40001

[commit-bot: I haz the power, 2016-04-05 08:56:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-05 08:57:00]

Description was changed from

==========
Fix treatment of rest pattern in array destructuring.

When seeing a rest pattern, we used to get the remaining elements from the
iterator by calling %concat_iterable_to_array on it.  This was wrong because it
caused an observable [[Get]] for @@iterator (which the iterator may not even
provide).

This CL gets rid of the call to %concat_iterable_to_array and does the iteration
manually in a simple while-loop.  It also gets rid of %concat_iterable_to_array
itself because there aren't any other uses of it.

BUG=v8:4759
LOG=n
R=adamk@chromium.org
==========

to

==========
Fix treatment of rest pattern in array destructuring.

When seeing a rest pattern, we used to get the remaining elements from the
iterator by calling %concat_iterable_to_array on it.  This was wrong because it
caused an observable [[Get]] for @@iterator (which the iterator may not even
provide).

This CL gets rid of the call to %concat_iterable_to_array and does the iteration
manually in a simple while-loop.  It also gets rid of %concat_iterable_to_array
itself because there aren't any other uses of it.

BUG=v8:4759
LOG=n
R=adamk@chromium.org

Committed: https://crrev.com/4edf16ddd97d8f23d35b57f46b30aada5e8e94a2
Cr-Commit-Position: refs/heads/master@{#35251}
==========

[commit-bot: I haz the power, 2016-04-05 08:57:02]

Patchset 3 (id:??) landed as
https://crrev.com/4edf16ddd97d8f23d35b57f46b30aada5e8e94a2
Cr-Commit-Position: refs/heads/master@{#35251}