Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1852673003: Revert of Ship --harmony-regexp-exec (Closed)

Created:
4 years, 8 months ago by Michael Hablich
Modified:
4 years, 8 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
Michael Hablich, v8-reviews_googlegroups.com, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Ship --harmony-regexp-exec (patchset #3 id:40001 of https://codereview.chromium.org/1847103002/ ) Reason for revert: breaks some chromium browser_tests: https://codereview.chromium.org/1848233002/ Original issue's description: > Ship --harmony-regexp-exec > > There are still spec compliance fixes to be made, but this patch > turns the flag to shipping to make sure we get more canary coverage > and performance data from the bots. > > BUG=v8:4602 > LOG=y > > Committed: https://crrev.com/84492bb66b340f4e0df36758e98fddbb10b5d1dc > Cr-Commit-Position: refs/heads/master@{#35181} TBR=littledan@chromium.org,adamk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4602 Committed: https://crrev.com/701911f9a0a43a358ab2769f25346404c8e4a7bf Cr-Commit-Position: refs/heads/master@{#35198}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M src/flag-definitions.h View 2 chunks +1 line, -1 line 0 comments Download
M test/mjsunit/es6/regexp-flags.js View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Hablich
Created Revert of Ship --harmony-regexp-exec
4 years, 8 months ago (2016-04-01 10:47:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852673003/1
4 years, 8 months ago (2016-04-01 10:47:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 10:47:34 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 10:48:25 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/701911f9a0a43a358ab2769f25346404c8e4a7bf
Cr-Commit-Position: refs/heads/master@{#35198}

Powered by Google App Engine
This is Rietveld 408576698