Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 1852663004: MockTransportChannel::GetRemoteSSLCertificate: Drop support for old signature (Closed)

Created:
4 years, 8 months ago by kwiberg-chromium
Modified:
4 years, 8 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org, torbjorng, tommi (sloooow) - chröme, perkj_chrome
Base URL:
https://chromium.googlesource.com/chromium/src.git@using-before
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MockTransportChannel::GetRemoteSSLCertificate: Drop support for old signature See https://codereview.webrtc.org/1802013002/#msg3. This removes support for the old TransportChannel::GetRemoteSSLCertificate signature. BUG=webrtc:5520 Committed: https://crrev.com/dcd733340d946e47c11bfe0e14fa2250cf9ff96c Cr-Commit-Position: refs/heads/master@{#387297}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M remoting/protocol/channel_socket_adapter_unittest.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
kwiberg-chromium
This can't land until after https://codereview.webrtc.org/1802013002/ has landed in WebRTC (and rolled into Chromium)---which is ...
4 years, 8 months ago (2016-04-02 00:57:09 UTC) #2
Sergey Ulanov
lgtm
4 years, 8 months ago (2016-04-05 18:05:55 UTC) #3
tommi (sloooow) - chröme
lgtm
4 years, 8 months ago (2016-04-07 15:29:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852663004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852663004/1
4 years, 8 months ago (2016-04-14 12:28:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/19064)
4 years, 8 months ago (2016-04-14 12:30:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852663004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852663004/20001
4 years, 8 months ago (2016-04-14 12:36:12 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-14 13:07:26 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 13:08:23 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dcd733340d946e47c11bfe0e14fa2250cf9ff96c
Cr-Commit-Position: refs/heads/master@{#387297}

Powered by Google App Engine
This is Rietveld 408576698