media: Only set property for Widevine in MediaDrmBridge

media: Only set property for Widevine in MediaDrmBridge

These properties are Widevine specific.

BUG=599759
Committed: https://crrev.com/aff41b52d83b10d4bf605559b8cdf6a5058cf306
Cr-Commit-Position: refs/heads/master@{#384654}

[xhwang, 2016-04-01 03:47:19]

Description was changed from

==========
media: Only set property for Widevine in MediaDrmBridge.

These properties are Widevine specific.

BUG=599759
==========

to

==========
media: Only set property for Widevine in MediaDrmBridge

These properties are Widevine specific.

BUG=599759
==========

[xhwang, 2016-04-01 03:47:19]

xhwang@chromium.org changed reviewers:
+ ddorwin@chromium.org

[xhwang, 2016-04-01 03:48:00]

PTAL

[ddorwin, 2016-04-01 16:49:52]

https://chromiumcodereview.appspot.com/1852643004/diff/1/media/base/android/j...
File media/base/android/java/src/org/chromium/media/MediaDrmBridge.java (right):

https://chromiumcodereview.appspot.com/1852643004/diff/1/media/base/android/j...
media/base/android/java/src/org/chromium/media/MediaDrmBridge.java:367:
Log.d(TAG, "Security level is Widevine specific.");
See below. This one I'm less sure of.

https://chromiumcodereview.appspot.com/1852643004/diff/1/media/base/android/j...
media/base/android/java/src/org/chromium/media/MediaDrmBridge.java:405:
Log.d(TAG, "Server certificate is Widevine specific.");
Not really "specific" - perhaps only support for/with/by?

Server certificates are a concept in the spec.

Alternatively, it might be better to just say "is not supported." That's more
accurate and prevents rot of the string if the logic changes.

https://chromiumcodereview.appspot.com/1852643004/diff/1/media/base/android/j...
media/base/android/java/src/org/chromium/media/MediaDrmBridge.java:759:
Log.e(TAG, "getSecurityLevel(): MediaDrm is null or scheme is not Widevine.");
As above, "or security level is not supported."

[xhwang, 2016-04-01 17:16:19]

PTAL again!

https://chromiumcodereview.appspot.com/1852643004/diff/1/media/base/android/j...
File media/base/android/java/src/org/chromium/media/MediaDrmBridge.java (right):

https://chromiumcodereview.appspot.com/1852643004/diff/1/media/base/android/j...
media/base/android/java/src/org/chromium/media/MediaDrmBridge.java:367:
Log.d(TAG, "Security level is Widevine specific.");
On 2016/04/01 16:49:52, ddorwin wrote:
> See below. This one I'm less sure of.

Done.

https://chromiumcodereview.appspot.com/1852643004/diff/1/media/base/android/j...
media/base/android/java/src/org/chromium/media/MediaDrmBridge.java:405:
Log.d(TAG, "Server certificate is Widevine specific.");
On 2016/04/01 16:49:52, ddorwin wrote:
> Not really "specific" - perhaps only support for/with/by?
> 
> Server certificates are a concept in the spec.
> 
> Alternatively, it might be better to just say "is not supported." That's more
> accurate and prevents rot of the string if the logic changes.

Done.

https://chromiumcodereview.appspot.com/1852643004/diff/1/media/base/android/j...
media/base/android/java/src/org/chromium/media/MediaDrmBridge.java:759:
Log.e(TAG, "getSecurityLevel(): MediaDrm is null or scheme is not Widevine.");
On 2016/04/01 16:49:52, ddorwin wrote:
> As above, "or security level is not supported."

Done.

[ddorwin, 2016-04-01 18:48:12]

lgtm

[xhwang, 2016-04-01 18:58:08]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2016-04-01 18:58:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1852643004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1852643004/20001

[commit-bot: I haz the power, 2016-04-01 19:08:28]

Description was changed from

==========
media: Only set property for Widevine in MediaDrmBridge

These properties are Widevine specific.

BUG=599759
==========

to

==========
media: Only set property for Widevine in MediaDrmBridge

These properties are Widevine specific.

BUG=599759
==========

[commit-bot: I haz the power, 2016-04-01 19:08:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-01 19:10:03]

Description was changed from

==========
media: Only set property for Widevine in MediaDrmBridge

These properties are Widevine specific.

BUG=599759
==========

to

==========
media: Only set property for Widevine in MediaDrmBridge

These properties are Widevine specific.

BUG=599759

Committed: https://crrev.com/aff41b52d83b10d4bf605559b8cdf6a5058cf306
Cr-Commit-Position: refs/heads/master@{#384654}
==========

[commit-bot: I haz the power, 2016-04-01 19:10:04]

Patchset 2 (id:??) landed as
https://crrev.com/aff41b52d83b10d4bf605559b8cdf6a5058cf306
Cr-Commit-Position: refs/heads/master@{#384654}