Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 185263012: DM: read image files without an extra copy (Closed)

Created:
6 years, 9 months ago by mtklein_C
Modified:
6 years, 9 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

DM: read image files without an extra copy BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13669

Patch Set 1 #

Patch Set 2 : reup #

Patch Set 3 : fmt #

Patch Set 4 : hal #

Patch Set 5 : three-lnies #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -24 lines) Patch
M dm/DMWriteTask.cpp View 1 2 3 4 chunks +26 lines, -21 lines 0 comments Download
M include/core/SkStream.h View 1 2 3 1 chunk +1 line, -0 lines 1 comment Download
M src/core/SkStream.cpp View 1 2 3 4 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mtklein_C
6 years, 9 months ago (2014-03-05 00:01:12 UTC) #1
hal.canary
lgtm
6 years, 9 months ago (2014-03-05 00:24:18 UTC) #2
mtklein_C
I am afraid I couldn't avoid touching the holy include/core...
6 years, 9 months ago (2014-03-05 00:25:13 UTC) #3
reed1
lgtm https://codereview.chromium.org/185263012/diff/70001/include/core/SkStream.h File include/core/SkStream.h (right): https://codereview.chromium.org/185263012/diff/70001/include/core/SkStream.h#newcode366 include/core/SkStream.h:366: size_t bytesWritten() const; We have this on several ...
6 years, 9 months ago (2014-03-05 13:23:46 UTC) #4
mtklein
On 2014/03/05 13:23:46, reed1 wrote: > lgtm > > https://codereview.chromium.org/185263012/diff/70001/include/core/SkStream.h > File include/core/SkStream.h (right): > ...
6 years, 9 months ago (2014-03-05 14:39:36 UTC) #5
mtklein
On 2014/03/05 13:23:46, reed1 wrote: > lgtm > > https://codereview.chromium.org/185263012/diff/70001/include/core/SkStream.h > File include/core/SkStream.h (right): > ...
6 years, 9 months ago (2014-03-05 14:39:37 UTC) #6
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 9 months ago (2014-03-05 14:40:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/185263012/70001
6 years, 9 months ago (2014-03-05 14:40:18 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 15:37:14 UTC) #9
Message was sent while issue was closed. 
Change committed as 13669

Powered by Google App Engine
This is Rietveld 408576698