Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 185263009: Replace scaled bitmap if entry already exist in cache. (Closed)

Created:
6 years, 9 months ago by reveman
Modified:
6 years, 9 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Replace scaled bitmap if entry already exist in cache. BUG=skia:2251 Committed: http://code.google.com/p/skia/source/detail?r=13667

Patch Set 1 #

Patch Set 2 : unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M src/core/SkScaledImageCache.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tests/ImageCacheTest.cpp View 1 1 chunk +15 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
reed1
doesn't seem wrong, but neither did the old version :) can we create a test ...
6 years, 9 months ago (2014-03-04 20:29:17 UTC) #1
reveman
PTAL
6 years, 9 months ago (2014-03-04 22:49:15 UTC) #2
reed1
lgtm
6 years, 9 months ago (2014-03-05 13:20:43 UTC) #3
reveman
The CQ bit was checked by reveman@chromium.org
6 years, 9 months ago (2014-03-05 13:29:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reveman@chromium.org/185263009/20001
6 years, 9 months ago (2014-03-05 13:29:34 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 13:44:20 UTC) #6
Message was sent while issue was closed.
Change committed as 13667

Powered by Google App Engine
This is Rietveld 408576698