Issue 185263003: Refactoring: Make script dependencies more object-oriented in push and merge scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 185263003: Refactoring: Make script dependencies more object-oriented in push and merge scripts. (Closed)

Created:
6 years, 9 months ago by Michael Achenbach

Modified:
6 years, 9 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Refactoring: Make script dependencies more object-oriented in push and merge scripts. - Connect the top-level scripts via inheritance and remove top-level functions - Options and option processing can be extended from base to subclass script This CL is split off from https://codereview.chromium.org/173983002/ BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19664

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+255 lines, -339 lines)			Patch
M	tools/push-to-trunk/auto_roll.py	View	4 chunks	+35 lines, -62 lines	0 comments	Download
M	tools/push-to-trunk/common_includes.py	View	4 chunks	+79 lines, -28 lines	0 comments	Download
M	tools/push-to-trunk/merge_to_branch.py	View	2 chunks	+54 lines, -86 lines	0 comments	Download
M	tools/push-to-trunk/push_to_trunk.py	View	2 chunks	+62 lines, -114 lines	0 comments	Download
M	tools/push-to-trunk/test_scripts.py	View	13 chunks	+25 lines, -49 lines	0 comments	Download

Total messages: 3 (0 generated)

Michael Achenbach

6 years, 9 months ago (2014-03-04 23:27:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19664 (tree was closed).