Don't setStyle the RenderView every style recalc

Don't setStyle the RenderView every style recalc

Prior to this CL, we were setting the style of the RenderView on every style
recalc because we were comparing the RenderView's overflow style with the wrong
value. This CL corrects the bug.

This CL doesn't have much effect yet, but it will become important in a future
CL when we use style modification on RenderLayers to scope compositing updates.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168254

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168412

[eseidel, 2014-03-01 08:09:54]

lgtm

[commit-bot: I haz the power, 2014-03-01 08:10:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/185263002/1

[esprehn, 2014-03-01 08:55:44]

lgtm

[commit-bot: I haz the power, 2014-03-01 09:49:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-01 09:49:22]

Retried try job too often on linux_blink for step(s) webkit_unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[abarth-chromium, 2014-03-01 09:54:23]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-03-01 09:54:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/185263002/1

[commit-bot: I haz the power, 2014-03-01 11:40:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-01 11:40:23]

Retried try job too often on linux_blink for step(s) webkit_unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[abarth-chromium, 2014-03-01 19:42:38]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-03-01 19:42:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/185263002/1

[commit-bot: I haz the power, 2014-03-01 21:02:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-01 21:02:05]

Retried try job too often on linux_blink for step(s) webkit_unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[abarth-chromium, 2014-03-01 21:59:52]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-03-01 22:00:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/185263002/1

[commit-bot: I haz the power, 2014-03-01 23:29:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-01 23:29:09]

Retried try job too often on linux_blink for step(s) webkit_unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[abarth-chromium, 2014-03-02 01:35:54]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-03-02 01:36:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/185263002/20001

[commit-bot: I haz the power, 2014-03-02 04:09:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-02 04:09:06]

Retried try job too often on win_layout for step(s) webkit_lint
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[esprehn, 2014-03-02 05:01:04]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-03-02 05:01:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/185263002/20001

[commit-bot: I haz the power, 2014-03-02 05:01:36]

Change committed as 168254

[ojan, 2014-03-03 03:30:52]

https://codereview.chromium.org/185263002/diff/20001/Source/web/WebViewImpl.cpp
File Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/185263002/diff/20001/Source/web/WebViewImpl.c...
Source/web/WebViewImpl.cpp:3378: layout();
Why was this change needed?

[abarth-chromium, 2014-03-03 03:50:11]

https://codereview.chromium.org/185263002/diff/20001/Source/web/WebViewImpl.cpp
File Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/185263002/diff/20001/Source/web/WebViewImpl.c...
Source/web/WebViewImpl.cpp:3378: layout();
On 2014/03/03 03:30:52, ojan wrote:
> Why was this change needed?

The call to setBaseBackgroundColor on line 3386 depends on compositing
information.  Previously, the unit test for this function, we just happened to
have clean compositing state.  After the other parts of this change, the unit
test triggers a chicken/egg assert.  Given that this API can be called at any
time, it seems like we need to clean out the compositing state.  An alternative
would be to delay actually setting the background color until the next
compositing update.

[apavlov, 2014-03-03 09:24:46]

A revert of this CL has been created in
https://codereview.chromium.org/183883009/ by apavlov@chromium.org.

The reason for reverting is: Crash-broke
fast/images/link-body-content-imageDimensionChanged-crash.html on "WebKit
Android (Nexus 4)".

[abarth-chromium, 2014-03-04 23:47:08]

The CQ bit was checked by abarth@chromium.org

[abarth-chromium, 2014-03-04 23:47:33]

This crash doesn't appear to exist at top of tree (but we were able to repro it
at the rev the bot crashed at).

[commit-bot: I haz the power, 2014-03-04 23:47:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/185263002/20001

[commit-bot: I haz the power, 2014-03-04 23:48:07]

Change committed as 168412