Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Side by Side Diff: src/type-info.cc

Issue 18526003: Fix unary op type feedback. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects-inl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 376 matching lines...) Expand 10 before | Expand all | Expand 10 after
387 } 387 }
388 388
389 389
390 Handle<Type> TypeFeedbackOracle::UnaryType(TypeFeedbackId id) { 390 Handle<Type> TypeFeedbackOracle::UnaryType(TypeFeedbackId id) {
391 Handle<Object> object = GetInfo(id); 391 Handle<Object> object = GetInfo(id);
392 if (!object->IsCode()) { 392 if (!object->IsCode()) {
393 return handle(Type::None(), isolate()); 393 return handle(Type::None(), isolate());
394 } 394 }
395 Handle<Code> code = Handle<Code>::cast(object); 395 Handle<Code> code = Handle<Code>::cast(object);
396 ASSERT(code->is_unary_op_stub()); 396 ASSERT(code->is_unary_op_stub());
397 return UnaryOpStub(code->extra_ic_state()).GetType(isolate()); 397 return UnaryOpStub(code->extended_extra_ic_state()).GetType(isolate());
398 } 398 }
399 399
400 400
401 void TypeFeedbackOracle::BinaryType(TypeFeedbackId id, 401 void TypeFeedbackOracle::BinaryType(TypeFeedbackId id,
402 Handle<Type>* left, 402 Handle<Type>* left,
403 Handle<Type>* right, 403 Handle<Type>* right,
404 Handle<Type>* result, 404 Handle<Type>* result,
405 Maybe<int>* fixed_right_arg) { 405 Maybe<int>* fixed_right_arg) {
406 Handle<Object> object = GetInfo(id); 406 Handle<Object> object = GetInfo(id);
407 if (!object->IsCode()) { 407 if (!object->IsCode()) {
(...skipping 307 matching lines...) Expand 10 before | Expand all | Expand 10 after
715 // TODO(verwaest): Return Smi rather than Integer32. 715 // TODO(verwaest): Return Smi rather than Integer32.
716 if (info.IsSmi()) return Representation::Integer32(); 716 if (info.IsSmi()) return Representation::Integer32();
717 if (info.IsInteger32()) return Representation::Integer32(); 717 if (info.IsInteger32()) return Representation::Integer32();
718 if (info.IsDouble()) return Representation::Double(); 718 if (info.IsDouble()) return Representation::Double();
719 if (info.IsNumber()) return Representation::Double(); 719 if (info.IsNumber()) return Representation::Double();
720 return Representation::Tagged(); 720 return Representation::Tagged();
721 } 721 }
722 722
723 723
724 } } // namespace v8::internal 724 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects-inl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698