Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 18526: Merge r8050 - When a function handling an event doesn't return a value, it le... (Closed)

Created:
11 years, 11 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
erg
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Merge r8050 - When a function handling an event doesn't return a value, it leaves the "event" object on the global context. This namespace pollution was causing some functionality that was trying to detect if we were in an event, such as popup blocking, to go wrong. BUG=6367 Review URL: http://codereview.chromium.org/18013 TBR=erg@google.com RNOTE=Fix to prevent us from incorrectly blocking popups Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8516

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M webkit/port/bindings/v8/v8_events.cpp View 6 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
laforge
11 years, 11 months ago (2009-01-22 23:06:21 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698