Remove content/plugin

Remove content/plugin

BUG=493212
Committed: https://crrev.com/7beb83cb738d700cd35c47c4026af6d55425e648
Cr-Commit-Position: refs/heads/master@{#384966}

[piman, 2016-04-01 23:17:03]

Patchset #2 (id:20001) has been deleted

[piman, 2016-04-01 23:17:07]

Patchset #1 (id:1) has been deleted

[piman, 2016-04-01 23:19:03]

piman@chromium.org changed reviewers:
+ jam@chromium.org

[piman, 2016-04-01 23:19:04]

Removing NPAPI in reasonably sized landable chunks. This is first of many.

[piman, 2016-04-01 23:53:42]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 23:54:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1852593004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1852593004/40001

[commit-bot: I haz the power, 2016-04-02 00:01:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-02 00:01:11]

Dry run: This issue passed the CQ dry run.

[jam, 2016-04-04 17:19:27]

lgtm

[jam, 2016-04-04 17:20:48]

On 2016/04/04 17:19:27, jam wrote:
> lgtm

I can take care of content/public/plugin btw, i just looked at it and it looks
trivial.

[piman, 2016-04-04 17:47:51]

The CQ bit was checked by piman@chromium.org

[piman, 2016-04-04 17:48:20]

On 2016/04/04 17:20:48, jam wrote:
> On 2016/04/04 17:19:27, jam wrote:
> > lgtm
> 
> I can take care of content/public/plugin btw, i just looked at it and it looks
> trivial.

I was looking at it, but it seems to be used by/for Pepper, so I don't think we
can remove.

[commit-bot: I haz the power, 2016-04-04 17:48:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1852593004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1852593004/40001

[jam, 2016-04-04 17:57:27]

On 2016/04/04 17:48:20, piman wrote:
> On 2016/04/04 17:20:48, jam wrote:
> > On 2016/04/04 17:19:27, jam wrote:
> > > lgtm
> > 
> > I can take care of content/public/plugin btw, i just looked at it and it
looks
> > trivial.
> 
> I was looking at it, but it seems to be used by/for Pepper, so I don't think
we
> can remove.

The only thing there is ChromeContentPluginClient::PreSandboxInitialization,
which calls 
#ifdef V8_USE_EXTERNAL_STARTUP_DATA
  gin::V8Initializer::LoadV8Snapshot();
  gin::V8Initializer::LoadV8Natives();
#endif

content can do this itself, i.e. PpapiPluginMain can just call this. i see other
calls to these 2 methods in content, so there's no layering violation.

if you want to add this to this cl or to a followup, that's fine.

[piman, 2016-04-04 18:05:25]

On Mon, Apr 4, 2016 at 10:57 AM, <jam@chromium.org> wrote:

> On 2016/04/04 17:48:20, piman wrote:
> > On 2016/04/04 17:20:48, jam wrote:
> > > On 2016/04/04 17:19:27, jam wrote:
> > > > lgtm
> > >
> > > I can take care of content/public/plugin btw, i just looked at it and
> it
> looks
> > > trivial.
> >
> > I was looking at it, but it seems to be used by/for Pepper, so I don't
> think
> we
> > can remove.
>
> The only thing there is
> ChromeContentPluginClient::PreSandboxInitialization,
> which calls
> #ifdef V8_USE_EXTERNAL_STARTUP_DATA
> gin::V8Initializer::LoadV8Snapshot();
> gin::V8Initializer::LoadV8Natives();
> #endif
>
> content can do this itself, i.e. PpapiPluginMain can just call this. i see
> other
> calls to these 2 methods in content, so there's no layering violation.
>
> if you want to add this to this cl or to a followup, that's fine.
>

Fair enough, sounds good, I'll do that as a follow-up.


>
> https://codereview.chromium.org/1852593004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2016-04-04 18:55:23]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2016-04-04 18:56:22]

Description was changed from

==========
Remove content/plugin

BUG=493212
==========

to

==========
Remove content/plugin

BUG=493212

Committed: https://crrev.com/7beb83cb738d700cd35c47c4026af6d55425e648
Cr-Commit-Position: refs/heads/master@{#384966}
==========

[commit-bot: I haz the power, 2016-04-04 18:56:23]

Patchset 1 (id:??) landed as
https://crrev.com/7beb83cb738d700cd35c47c4026af6d55425e648
Cr-Commit-Position: refs/heads/master@{#384966}