Gerrit git cl: implement git cl patch.

Gerrit git cl: implement git cl patch.

BUG=579182
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299644

[tandrii(chromium), 2016-04-01 18:03:38]

tandrii@chromium.org changed reviewers:
+ andybons@chromium.org

[tandrii(chromium), 2016-04-01 18:03:39]

PTAL

This is the last major missing feature in git cl. The expectations for Rietveld
side didn't change, so I think it should still be working. I also ran local
tests with Rietveld and Gerrit repositories, and all my tests finally passed.

The patch looks large, but:
1) a big chunk is new tests for regexes that parse Rietveld/Gerrit URLs into
issue/patchset/hostname => extra test coverage
2) tests for gerrit case
3) code in _RietveldCodereviewImpl is making use parsed_issue_arg in the "def
PatchIssue" code.

[Bons, 2016-04-01 18:24:29]

lgtm

https://codereview.chromium.org/1852593002/diff/100001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1852593002/diff/100001/git_cl.py#newcode1888
git_cl.py:1888: RunGit(['cherry-pick', 'FETCH_HEAD'])
checkout FETCH_HEAD will result in a detached HEAD state. Does cherry-pick not
and just apply it to the current branch?

https://codereview.chromium.org/1852593002/diff/100001/git_cl.py#newcode1900
git_cl.py:1900: # But old old UI is
https://domain/#/c/<issue_number>[/[patchset]]
s/old old/current GWT UI

[tandrii(chromium), 2016-04-01 18:33:09]

thanks for review.

https://codereview.chromium.org/1852593002/diff/100001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1852593002/diff/100001/git_cl.py#newcode1888
git_cl.py:1888: RunGit(['cherry-pick', 'FETCH_HEAD'])
On 2016/04/01 18:24:29, Bons wrote:
> checkout FETCH_HEAD will result in a detached HEAD state. Does cherry-pick not
> and just apply it to the current branch?

correct, just went to my test place and verified that's the case. FETCH_HEAD is
merely resolving to some <hash>. What's making detached state is "checkout", not
FETCH_HEAD.

https://codereview.chromium.org/1852593002/diff/100001/git_cl.py#newcode1900
git_cl.py:1900: # But old old UI is
https://domain/#/c/<issue_number>[/[patchset]]
On 2016/04/01 18:24:29, Bons wrote:
> s/old old/current GWT UI

Done.

[tandrii(chromium), 2016-04-01 18:33:13]

The CQ bit was checked by tandrii@chromium.org

[tandrii(chromium), 2016-04-01 18:33:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
andybons@chromium.org
Link to the patchset: https://codereview.chromium.org/1852593002/#ps120001
(title: "review")

[tandrii(chromium), 2016-04-01 18:35:43]

hm, CQ doesn't seem to want to process this.

[tandrii(chromium), 2016-04-01 18:35:47]

The CQ bit was unchecked by tandrii@chromium.org

[tandrii(chromium), 2016-04-01 18:35:51]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-04-01 19:00:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1852593002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1852593002/120001

[commit-bot: I haz the power, 2016-04-01 19:03:13]

Description was changed from

==========
Gerrit git cl: implement git cl patch.

BUG=579182
==========

to

==========
Gerrit git cl: implement git cl patch.

BUG=579182

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299644
==========

[commit-bot: I haz the power, 2016-04-01 19:03:14]

Committed patchset #7 (id:120001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299644

[Will Harris, 2016-04-01 19:19:03]

On 2016/04/01 19:03:14, commit-bot: I haz the power wrote:
> Committed patchset #7 (id:120001) as
> http://src.chromium.org/viewvc/chrome?view=rev&revision=299644

this CL is possibly causing issues patching, seen on two separate issues

https://build.chromium.org/p/tryserver.chromium.win/builders/win10_chromium_x...
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64...
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64...

PTAL?

[tandrii(chromium), 2016-04-01 19:20:22]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/1848393002/ by tandrii@chromium.org.

The reason for reverting is: just in case..