Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 1852553003: [builtins] Migrate Math.clz32 to a TurboFan builtin. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Migrate Math.clz32 to a TurboFan builtin. This allows us to remove the troublesome %_MathClz32 intrinsic and also allows us to utilize the functionality that is already available in TurboFan. Also introduce a proper NumberClz32 operator so we don't need to introduce a machine operator at the JS level. R=epertoso@chromium.org Committed: https://crrev.com/eaa92feb9a5a8ab822b478a667482bdf2e9709f7 Cr-Commit-Position: refs/heads/master@{#35208}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -66 lines) Patch
M src/bootstrapper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/builtins.cc View 1 chunk +68 lines, -0 lines 0 comments Download
M src/compiler/code-stub-assembler.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/js-builtin-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 3 chunks +22 lines, -1 line 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/representation-change.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/js/math.js View 2 chunks +0 lines, -7 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-maths.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M test/cctest/compiler/test-code-stub-assembler.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/mjsunit/asm/math-clz32.js View 2 chunks +1 line, -4 lines 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 8 months ago (2016-04-01 13:00:14 UTC) #1
Benedikt Meurer
Hey Enrico, Another small refactoring. Please take a look. Thanks, Benedikt
4 years, 8 months ago (2016-04-01 13:00:51 UTC) #2
epertoso
lgtm
4 years, 8 months ago (2016-04-01 13:09:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852553003/1
4 years, 8 months ago (2016-04-01 14:33:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 14:35:35 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 14:36:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eaa92feb9a5a8ab822b478a667482bdf2e9709f7
Cr-Commit-Position: refs/heads/master@{#35208}

Powered by Google App Engine
This is Rietveld 408576698