Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.cpp

Issue 1852533002: Remove alpha/depth/stencil/antialias from WGC3D::Attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@premul
Patch Set: rm-alphadepthetc: renamevar Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.cpp
diff --git a/third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.cpp b/third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.cpp
index 41aba4d95f87a6aca1fcb5b993cc6edf415e2e3c..c4fd16b05f8034e73af7c2b2f1339b871d87b973 100644
--- a/third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.cpp
+++ b/third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.cpp
@@ -21,24 +21,13 @@ WebGLContextAttributes toWebGLContextAttributes(const CanvasContextCreationAttri
return result;
}
-WebGraphicsContext3D::Attributes toWebGraphicsContext3DAttributes(const WebGLContextAttributes& attrs, const WebString& topDocumentURL, Settings* settings, unsigned webGLVersion)
+WebGraphicsContext3D::Attributes toWebGraphicsContext3DAttributes(const WebGLContextAttributes& attrs, const WebString& topDocumentURL, unsigned webGLVersion)
{
WebGraphicsContext3D::Attributes result;
- result.alpha = attrs.alpha();
- result.depth = attrs.depth();
- result.stencil = attrs.stencil();
- result.antialias = attrs.antialias();
- if (attrs.antialias()) {
- if (settings && !settings->openGLMultisamplingEnabled())
- result.antialias = false;
- }
result.failIfMajorPerformanceCaveat = attrs.failIfMajorPerformanceCaveat();
-
result.shareResources = false;
result.preferDiscreteGPU = true;
-
result.topDocumentURL = topDocumentURL;
-
result.webGLVersion = webGLVersion;
return result;
}

Powered by Google App Engine
This is Rietveld 408576698