Need to set the MICROSOFT_TABLETPENSERVICE_PROPERTY window property even for child windows

Need to set the MICROSOFT_TABLETPENSERVICE_PROPERTY window property even for child windows
to properly disable Flicks.

Added Tpcshrd.h header
All HWNDS need to have Flicks disabled

BUG=595842
Committed: https://crrev.com/fd3c1f989b2e3012be9e6cffdb6bfa86b9fda99e
Cr-Commit-Position: refs/heads/master@{#385846}

[kylix_rd, 2016-03-31 18:19:20]

Description was changed from

==========
Need to set the MICROSOFT_TABLETPENSERVICE_PROPERTY window property even for
child windows
to properly disable Flicks.

Added Tpcshrd.h header
All HWNDS need to have Flicks disabled

BUG=595842
==========

to

==========
Need to set the MICROSOFT_TABLETPENSERVICE_PROPERTY window property even for
child windows
to properly disable Flicks.

Added Tpcshrd.h header
All HWNDS need to have Flicks disabled

BUG=595842
==========

[kylix_rd, 2016-03-31 18:19:20]

kylixrd@chromium.org changed reviewers:
+ ananta@chromium.org, rbyers@chromium.org

[Rick Byers, 2016-03-31 21:12:40]

Sounds like a good idea to me, but I definitely don't have the Windows-specific
expertise to comment on the details of the code changes.

[Rick Byers, 2016-03-31 21:13:02]

rbyers@chromium.org changed reviewers:
- rbyers@chromium.org

[kylix_rd, 2016-04-04 21:04:02]

kylixrd@chromium.org changed reviewers:
+ sky@chromium.org

[kylix_rd, 2016-04-04 21:05:26]

Based on a refactoring suggestion from ananta@, changes to base/win/win_util was
necessary.

[ananta, 2016-04-04 21:17:58]

lgtm % nits

https://codereview.chromium.org/1852503002/diff/20001/base/win/win_util.cc
File base/win/win_util.cc (right):

https://codereview.chromium.org/1852503002/diff/20001/base/win/win_util.cc#ne...
base/win/win_util.cc:11: #include <tchar.h>
Please fix the include order if possible for this file

https://codereview.chromium.org/1852503002/diff/20001/base/win/win_util.h
File base/win/win_util.h (right):

https://codereview.chromium.org/1852503002/diff/20001/base/win/win_util.h#new...
base/win/win_util.h:179: // disable pen flick gestures for the given HWND. If
handle == true, then the
allow == true?

https://codereview.chromium.org/1852503002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/legacy_render_widget_host_win.cc (right):

https://codereview.chromium.org/1852503002/diff/20001/content/browser/rendere...
content/browser/renderer_host/legacy_render_widget_host_win.cc:20: #include
"base/win/win_util.h"
Please fix the include order

[kylix_rd, 2016-04-04 21:40:52]

https://codereview.chromium.org/1852503002/diff/20001/base/win/win_util.cc
File base/win/win_util.cc (right):

https://codereview.chromium.org/1852503002/diff/20001/base/win/win_util.cc#ne...
base/win/win_util.cc:11: #include <tchar.h>
On 2016/04/04 21:17:59, ananta wrote:
> Please fix the include order if possible for this file

Done.

https://codereview.chromium.org/1852503002/diff/20001/base/win/win_util.h
File base/win/win_util.h (right):

https://codereview.chromium.org/1852503002/diff/20001/base/win/win_util.h#new...
base/win/win_util.h:179: // disable pen flick gestures for the given HWND. If
handle == true, then the
On 2016/04/04 21:17:59, ananta wrote:
> allow == true?

Done.

https://codereview.chromium.org/1852503002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/legacy_render_widget_host_win.cc (right):

https://codereview.chromium.org/1852503002/diff/20001/content/browser/rendere...
content/browser/renderer_host/legacy_render_widget_host_win.cc:20: #include
"base/win/win_util.h"
On 2016/04/04 21:17:59, ananta wrote:
> Please fix the include order

Done.

[kylix_rd, 2016-04-06 19:36:16]

Any more comments, suggestions, smart-remarks?

[sky, 2016-04-07 17:57:55]

https://codereview.chromium.org/1852503002/diff/40001/base/win/win_util.cc
File base/win/win_util.cc (right):

https://codereview.chromium.org/1852503002/diff/40001/base/win/win_util.cc#ne...
base/win/win_util.cc:699: // Disable/Enable flick gestures
You have the comment in the header, so no comment is necessary here.

https://codereview.chromium.org/1852503002/diff/40001/base/win/win_util.h
File base/win/win_util.h (right):

https://codereview.chromium.org/1852503002/diff/40001/base/win/win_util.h#new...
base/win/win_util.h:181: BASE_EXPORT void AllowFlicks(HWND hwnd, bool allow);
AllowFlicks with a boolean parameter named allow is rather confusing. I vote for
two functions: EnableFlicks and DisableFlicks

[sky, 2016-04-07 17:58:48]

sky@chromium.org changed reviewers:
+ scottmg@chromium.org

[sky, 2016-04-07 17:58:49]

Neither ananta or myself are owners of base/win. So, +scottmg

[kylix_rd, 2016-04-07 18:46:25]

https://codereview.chromium.org/1852503002/diff/40001/base/win/win_util.cc
File base/win/win_util.cc (right):

https://codereview.chromium.org/1852503002/diff/40001/base/win/win_util.cc#ne...
base/win/win_util.cc:699: // Disable/Enable flick gestures
On 2016/04/07 17:57:54, sky wrote:
> You have the comment in the header, so no comment is necessary here.

Done.

https://codereview.chromium.org/1852503002/diff/40001/base/win/win_util.h
File base/win/win_util.h (right):

https://codereview.chromium.org/1852503002/diff/40001/base/win/win_util.h#new...
base/win/win_util.h:181: BASE_EXPORT void AllowFlicks(HWND hwnd, bool allow);
On 2016/04/07 17:57:54, sky wrote:
> AllowFlicks with a boolean parameter named allow is rather confusing. I vote
for
> two functions: EnableFlicks and DisableFlicks

I'd rather this have been a method on a common base between the
HWNDMessageHandler & LegacyRenderWidgetHostHWND. At that point it would have
been a "property" of the class and the method would have been something like
HWNDBase::setAllowFlicks(bool allow){}.

Alas, that's not the case so the consolidation into a single function is causing
some confusion.

I'll be happy to break it into separate functions.

https://codereview.chromium.org/1852503002/diff/40001/base/win/win_util.h#new...
base/win/win_util.h:181: BASE_EXPORT void AllowFlicks(HWND hwnd, bool allow);
On 2016/04/07 17:57:54, sky wrote:
> AllowFlicks with a boolean parameter named allow is rather confusing. I vote
for
> two functions: EnableFlicks and DisableFlicks

Done.

[sky, 2016-04-07 20:02:38]

LGTM

[scottmg, 2016-04-07 20:25:52]

base/win lgtm

[kylix_rd, 2016-04-07 20:30:13]

The CQ bit was checked by kylixrd@chromium.org

[kylix_rd, 2016-04-07 20:30:14]

The patchset sent to the CQ was uploaded after l-g-t-m from ananta@chromium.org
Link to the patchset: https://codereview.chromium.org/1852503002/#ps60001
(title: "More changes based on feedback/suggestions")

[commit-bot: I haz the power, 2016-04-07 20:31:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1852503002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1852503002/60001

[commit-bot: I haz the power, 2016-04-07 21:05:32]

Description was changed from

==========
Need to set the MICROSOFT_TABLETPENSERVICE_PROPERTY window property even for
child windows
to properly disable Flicks.

Added Tpcshrd.h header
All HWNDS need to have Flicks disabled

BUG=595842
==========

to

==========
Need to set the MICROSOFT_TABLETPENSERVICE_PROPERTY window property even for
child windows
to properly disable Flicks.

Added Tpcshrd.h header
All HWNDS need to have Flicks disabled

BUG=595842
==========

[commit-bot: I haz the power, 2016-04-07 21:05:33]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-07 21:07:16]

Description was changed from

==========
Need to set the MICROSOFT_TABLETPENSERVICE_PROPERTY window property even for
child windows
to properly disable Flicks.

Added Tpcshrd.h header
All HWNDS need to have Flicks disabled

BUG=595842
==========

to

==========
Need to set the MICROSOFT_TABLETPENSERVICE_PROPERTY window property even for
child windows
to properly disable Flicks.

Added Tpcshrd.h header
All HWNDS need to have Flicks disabled

BUG=595842

Committed: https://crrev.com/fd3c1f989b2e3012be9e6cffdb6bfa86b9fda99e
Cr-Commit-Position: refs/heads/master@{#385846}
==========

[commit-bot: I haz the power, 2016-04-07 21:07:17]

Patchset 4 (id:??) landed as
https://crrev.com/fd3c1f989b2e3012be9e6cffdb6bfa86b9fda99e
Cr-Commit-Position: refs/heads/master@{#385846}