Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 18525002: Revert "Remove BinaryOp::result_type" (Closed)

Created:
7 years, 5 months ago by rossberg
Modified:
7 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Revert "Remove BinaryOp::result_type" This reverts https://code.google.com/p/v8/source/detail?r=15265, due to performance regression. TBR=jkummerow@chromium.org BUG= Committed: http://code.google.com/p/v8/source/detail?r=15444

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M src/ast.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/type-info.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/typing.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
7 years, 5 months ago (2013-07-02 11:57:33 UTC) #1
rossberg
Committed patchset #1 manually as r15444 (presubmit successful).
7 years, 5 months ago (2013-07-02 11:57:49 UTC) #2
Jakob Kummerow
7 years, 5 months ago (2013-07-02 11:57:57 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698