Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1852473002: Fix generated server code to be strong mode compliant (Closed)

Created:
4 years, 8 months ago by Brian Wilkerson
Modified:
4 years, 8 months ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org, Paul Berry
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -79 lines) Patch
M pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart View 51 chunks +71 lines, -71 lines 0 comments Download
M pkg/analysis_server/lib/plugin/protocol/protocol.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M pkg/analysis_server/tool/spec/api.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/codegen_dart_protocol.dart View 2 chunks +2 lines, -2 lines 1 comment Download

Messages

Total messages: 7 (3 generated)
Brian Wilkerson
4 years, 8 months ago (2016-03-31 17:37:41 UTC) #2
scheglov
LGTM
4 years, 8 months ago (2016-03-31 17:39:58 UTC) #3
Brian Wilkerson
Committed patchset #1 (id:1) manually as 301a6a4725cfe2901133d173541a00ca8323dcb9 (presubmit successful).
4 years, 8 months ago (2016-03-31 17:44:47 UTC) #5
Paul Berry
4 years, 8 months ago (2016-03-31 18:30:44 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/1852473002/diff/1/pkg/analysis_server/tool/sp...
File pkg/analysis_server/tool/spec/codegen_dart_protocol.dart (right):

https://codereview.chromium.org/1852473002/diff/1/pkg/analysis_server/tool/sp...
pkg/analysis_server/tool/spec/codegen_dart_protocol.dart:983:
'jsonDecoder.decodeList($jsonPath, $json, ${itemCode.asClosure}) as
${dartType(type)}');
Would it be possible to avoid the type cast by making decodeList a generic
function, so that instead of:

  jsonDecoder.decodeList(...) as List<Foo>

we do this instead?

  jsonDecoder.decodeList/*<Foo>*/(...)

Powered by Google App Engine
This is Rietveld 408576698