Source/core/rendering/svg/RenderSVGRect.h - Issue 185243002: [FastTextAutosizer] Fix incorrect override for RenderSVGShape::isEmpty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/RenderSVGRect.h

Issue 185243002: [FastTextAutosizer] Fix incorrect override for RenderSVGShape::isEmpty (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update per reviewer comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/svg/RenderSVGRect.h

diff --git a/Source/core/rendering/svg/RenderSVGRect.h b/Source/core/rendering/svg/RenderSVGRect.h

index afc65e31342d0e8d516beeb012eec12bf026501c..7ae3962575545e9faab11d983deee5fc134991c9 100644

--- a/Source/core/rendering/svg/RenderSVGRect.h

+++ b/Source/core/rendering/svg/RenderSVGRect.h

@@ -42,7 +42,7 @@ private:

virtual const char* renderName() const OVERRIDE { return "RenderSVGRect"; }

virtual void updateShapeFromElement() OVERRIDE;

- virtual bool isEmpty() const OVERRIDE { return m_usePathFallback ? RenderSVGShape::isEmpty() : m_fillBoundingBox.isEmpty(); }

+ virtual bool isShapeEmpty() const OVERRIDE { return m_usePathFallback ? RenderSVGShape::isShapeEmpty() : m_fillBoundingBox.isEmpty(); }

virtual void fillShape(GraphicsContext*) const OVERRIDE;

virtual void strokeShape(GraphicsContext*) const OVERRIDE;

virtual bool shapeDependentStrokeContains(const FloatPoint&) OVERRIDE;