Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1852423003: Avoid unnecessary DocumentElementSetMap hash table updates. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, nessy, mlamouri+watch-blink_chromium.org, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews, vcarbune.chromium, philipj_slow
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid unnecessary DocumentElementSetMap hash table updates. Alter the representation of the singleton map used to track the correspondence between Documents and their media elements. Additions and removals become slightly cheaper as a result. R= BUG= Committed: https://crrev.com/297e542070abc169e85084acb4f45adb5ef7a3cb Cr-Commit-Position: refs/heads/master@{#385126}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 3 chunks +21 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look. HeapHashMaps with HeapHashMap part objects as values doesn't buy us much ...
4 years, 8 months ago (2016-04-05 07:02:36 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-05 07:03:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852423003/1
4 years, 8 months ago (2016-04-05 07:44:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 07:56:50 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 07:57:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/297e542070abc169e85084acb4f45adb5ef7a3cb
Cr-Commit-Position: refs/heads/master@{#385126}

Powered by Google App Engine
This is Rietveld 408576698