Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1852403002: S390: Fix allocation-site-info.js failure (Closed)

Created:
4 years, 8 months ago by john.yan
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Fix allocation-site-info.js failure Mask used in MacroAssembler::TestJSArrayForAllocationMemento was not supposed to shifted right by 16 bits before loaded in to register r0. R=michael_dawson@ca.ibm.com,mbrandy@us.ibm.com,joransiu@ca.ibm.com BUG= Committed: https://crrev.com/99796f040b90704486d861778c33251b52d54792 Cr-Commit-Position: refs/heads/master@{#35247}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M src/s390/macro-assembler-s390.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
john.yan
PTAL
4 years, 8 months ago (2016-04-04 19:23:47 UTC) #1
JoranSiu
On 2016/04/04 19:23:47, john.yan wrote: > PTAL lgtm
4 years, 8 months ago (2016-04-04 19:30:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852403002/1
4 years, 8 months ago (2016-04-04 19:31:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 19:51:01 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 19:51:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99796f040b90704486d861778c33251b52d54792
Cr-Commit-Position: refs/heads/master@{#35247}

Powered by Google App Engine
This is Rietveld 408576698