tools/perf/chrome_telemetry_build/telemetry_binary_manager.isolate - Issue 1852393002: Fix stack symbolization in Telemetry on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/chrome_telemetry_build/telemetry_binary_manager.isolate

Issue 1852393002: Fix stack symbolization in Telemetry on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable stacktrace_unittest on Windows again. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/chrome_telemetry_build/telemetry_binary_manager.isolate

diff --git a/tools/perf/chrome_telemetry_build/telemetry_binary_manager.isolate b/tools/perf/chrome_telemetry_build/telemetry_binary_manager.isolate

index da18846ee793da4d73e7a42b7e4484232ed1f8c3..8d7d8f5c564eb4576579e94f31db75f5cb416ef4 100644

--- a/tools/perf/chrome_telemetry_build/telemetry_binary_manager.isolate

+++ b/tools/perf/chrome_telemetry_build/telemetry_binary_manager.isolate

@@ -3,16 +3,6 @@

# found in the LICENSE file.

{

'conditions': [

- ['OS=="win"', {

- 'variables': {

- 'files': [

- '<(PRODUCT_DIR)/crash_service<(EXECUTABLE_SUFFIX)',

- '../../../components/crash/content/tools/generate_breakpad_symbols.py',

- ],

- },

- }],

- ],

- 'conditions': [

['OS=="android" or OS=="linux" or OS=="mac" or OS=="win"', {

'variables': {

'files': [