Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: tools/perf/core/stacktrace_unittest.py

Issue 1852393002: Fix stack symbolization in Telemetry on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/core/stacktrace_unittest.py
diff --git a/tools/perf/core/stacktrace_unittest.py b/tools/perf/core/stacktrace_unittest.py
index 7d2e15998ab45b15c273aa71e62326f2febfaa1e..7f17cd216b9ac11303dcb9a3f1cd2ce9693cc121 100644
--- a/tools/perf/core/stacktrace_unittest.py
+++ b/tools/perf/core/stacktrace_unittest.py
@@ -9,8 +9,9 @@ from telemetry.testing import tab_test_case
class TabStackTraceTest(tab_test_case.TabTestCase):
- # TODO(dyen): For now this works on a mac & linux but continue to expand this.
- @decorators.Enabled('mac', 'linux')
+ # TODO(dyen): For now this doesn't work on Android but continue to
+ # expand this.
+ @decorators.Enabled('mac', 'linux', 'win')
# Stack traces do not currently work on 10.6, but they are also being
# disabled shortly so just disable it for now.
@decorators.Disabled('snowleopard')
@@ -20,9 +21,8 @@ class TabStackTraceTest(tab_test_case.TabTestCase):
except exceptions.DevtoolsTargetCrashException as e:
self.assertIn('Thread 0 (crashed)', '\n'.join(e.stack_trace))
- # Currently stack traces do not work on windows: http://crbug.com/476110
- # Linux stack traces depends on fission support: http://crbug.com/405623
- @decorators.Enabled('mac', 'linux')
+ # Stack traces aren't working on Android yet.
+ @decorators.Enabled('mac', 'linux', 'win')
@decorators.Disabled('snowleopard')
def testCrashSymbols(self):
try:

Powered by Google App Engine
This is Rietveld 408576698