Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: tools/perf/core/stacktrace_unittest.py

Issue 1852393002: Fix stack symbolization in Telemetry on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable stacktrace_unittest on Windows again. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/chrome_telemetry_build/telemetry_binary_manager.isolate ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from telemetry.core import exceptions 5 from telemetry.core import exceptions
6 from telemetry import decorators 6 from telemetry import decorators
7 from telemetry.testing import tab_test_case 7 from telemetry.testing import tab_test_case
8 8
9 9
10 class TabStackTraceTest(tab_test_case.TabTestCase): 10 class TabStackTraceTest(tab_test_case.TabTestCase):
11 11
12 # TODO(dyen): For now this works on a mac & linux but continue to expand this. 12 # TODO(dyen): For now this doesn't work on Android but continue to
13 # expand this.
14 # TODO(kbr): this test doesn't work on the Windows Swarming bots
15 # yet. http://crbug.com/561763
13 @decorators.Enabled('mac', 'linux') 16 @decorators.Enabled('mac', 'linux')
14 # Stack traces do not currently work on 10.6, but they are also being 17 # Stack traces do not currently work on 10.6, but they are also being
15 # disabled shortly so just disable it for now. 18 # disabled shortly so just disable it for now.
16 @decorators.Disabled('snowleopard') 19 @decorators.Disabled('snowleopard')
17 def testStackTrace(self): 20 def testStackTrace(self):
18 try: 21 try:
19 self._tab.Navigate('chrome://crash', timeout=5) 22 self._tab.Navigate('chrome://crash', timeout=5)
20 except exceptions.DevtoolsTargetCrashException as e: 23 except exceptions.DevtoolsTargetCrashException as e:
21 self.assertIn('Thread 0 (crashed)', '\n'.join(e.stack_trace)) 24 self.assertIn('Thread 0 (crashed)', '\n'.join(e.stack_trace))
22 25
23 # Currently stack traces do not work on windows: http://crbug.com/476110 26 # Stack traces aren't working on Android yet.
24 # Linux stack traces depends on fission support: http://crbug.com/405623 27 # TODO(kbr): this test doesn't work on the Windows Swarming bots
28 # yet. http://crbug.com/561763
25 @decorators.Enabled('mac', 'linux') 29 @decorators.Enabled('mac', 'linux')
26 @decorators.Disabled('snowleopard') 30 @decorators.Disabled('snowleopard')
27 def testCrashSymbols(self): 31 def testCrashSymbols(self):
28 try: 32 try:
29 self._tab.Navigate('chrome://crash', timeout=5) 33 self._tab.Navigate('chrome://crash', timeout=5)
30 except exceptions.DevtoolsTargetCrashException as e: 34 except exceptions.DevtoolsTargetCrashException as e:
31 self.assertIn('CrashIntentionally', '\n'.join(e.stack_trace)) 35 self.assertIn('CrashIntentionally', '\n'.join(e.stack_trace))
OLDNEW
« no previous file with comments | « tools/perf/chrome_telemetry_build/telemetry_binary_manager.isolate ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698