appengine/findit/third_party/uritemplate - Issue 1852383002: [Findit] Integrate with Fracas through Pub/Sub.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/findit/third_party/uritemplate

Issue 1852383002: [Findit] Integrate with Fracas through Pub/Sub. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 ../../third_party/uritemplate/uritemplate/
	mimee 2016/04/07 23:43:09 I am not very familiar with this practice. Is this I am not very familiar with this practice. Is this generated code? Specifying lib directory in appengine_config.py is very simple. stgao 2016/04/08 01:14:08 These are links to avoid copy those codes. This is Show quoted text On 2016/04/07 23:43:09, mimee wrote: > I am not very familiar with this practice. Is this generated code? Specifying > lib directory in appengine_config.py is very simple. These are links to avoid copy those codes. This is the convention in the infra repo. And I guess this committed CL https://codereview.chromium.org/1866053002/ resolved your doubt.
OLD	NEW