appengine/findit/templates/crash/crash_config.html - Issue 1852383002: [Findit] Integrate with Fracas through Pub/Sub.

Side by Side Diff: appengine/findit/templates/crash/crash_config.html

Issue 1852383002: [Findit] Integrate with Fracas through Pub/Sub. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <head>

	3 <meta charset="utf-8">

	4 <script src="//ajax.googleapis.com/ajax/libs/jquery/1.11.1/jquery.min.js"></sc ript>
	mimee 2016/04/07 23:43:09 This might just be a sample internal page, but jqu This might just be a sample internal page, but jquery is too heavy for this. Not using jquery is about the same number of lines of code. Also, why is script in <head>? stgao 2016/04/08 01:14:08 We prefer jquery over native javascript functions Show quoted text On 2016/04/07 23:43:09, mimee wrote: > This might just be a sample internal page, but jquery is too heavy for this. Not > using jquery is about the same number of lines of code. We prefer jquery over native javascript functions & ajax for simplicity and consistence within the Findit app. Show quoted text > > Also, why is script in <head>? What's the alternative? mimee 2016/04/08 15:36:03 The alternative is to put script on bottom because Show quoted text On 2016/04/08 01:14:08, stgao wrote: > On 2016/04/07 23:43:09, mimee wrote: > > This might just be a sample internal page, but jquery is too heavy for this. > Not > > using jquery is about the same number of lines of code. > We prefer jquery over native javascript functions & ajax for simplicity and > consistence within the Findit app. > > > > > Also, why is script in <head>? > What's the alternative? The alternative is to put script on bottom because loading script blocks parallel downloads and slows down the webpage, as per convention. Although this is a case where the script modifies the core parts of the html page (not desired behavior), so loading it faster earlier doesn't actually help that much. It is better to not pass html code around though, if possible. stgao 2016/04/11 20:32:19 Ah, I see. But if we move all scripts to the end o Show quoted text On 2016/04/08 15:36:03, mimee wrote: > On 2016/04/08 01:14:08, stgao wrote: > > On 2016/04/07 23:43:09, mimee wrote: > > > This might just be a sample internal page, but jquery is too heavy for this. > > Not > > > using jquery is about the same number of lines of code. > > We prefer jquery over native javascript functions & ajax for simplicity and > > consistence within the Findit app. > > > > > > > > Also, why is script in <head>? > > What's the alternative? > > The alternative is to put script on bottom because loading script blocks > parallel downloads and slows down the webpage, as per convention. Ah, I see. But if we move all scripts to the end of page, the user might see a page with empty config values during page loading. Thus, I'd leave them in the header. Show quoted text > > Although this is a case where the script modifies the core parts of the html > page (not desired behavior), so loading it faster earlier doesn't actually help > that much. It is better to not pass html code around though, if possible. Only the values of textareas are passed in Javascript for better formatting. It seems no obvious workarounds to me.
	5 <link rel="stylesheet" href="/common.css"></link>

	6 <title>Crash Configuration</title>

	7 <script>

	8 var crash = {};

	9 crash.fracas = {{ fracas \| tojson \| safe }};

	10

	11 function getJsonOfTextarea(textId) {

	12 return JSON.parse($('#' + textId).val());

	13 }

	14

	15 function getStringFromJson(json) {

	16 return JSON.stringify(json, null, ' ');

	17 }

	18

	19 function save(e) {

	20 var newConfig = {

	21 'fracas': getJsonOfTextarea('fracas'),

	22 };

	23 $.post('/crash/config', { data: JSON.stringify(newConfig) }).done(function () {

	24 window.location.reload(); // Reload after successful saving.

	25 }).fail(function(xhr) {

	26 // Replace the whole page with errors from server side.

	27 document.body.outerHTML = xhr.responseText;

	28 });

	29 e.preventDefault();

	30 }

	31

	32 $(document).ready(function() {

	33 $('#save-button').click(save);

	34 $('#fracas').val(getStringFromJson(crash.fracas));

	35 });

	36 </script>

	37 </head>

	38 <body>

	39 <h3>Crash Configuration</h3>

	40 <div>

	41 Settings for Fracas:<br>

	42 <textarea id="fracas" rows="20" cols="80"></textarea>

	43 </div>

	44 <button type="submit" id="save-button">Save</button>

	45 </body>

OLD	NEW