[Findit] Integrate with Fracas through Pub/Sub.

appengine/findit/crash/fracas.py

+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Process crashes from Chrome crash server and find culprits for them."""
+
+
+def FindCulpritForChromeCrash(  # Not implemented yet pylint: disable=W0613
+    channel, platform, signature, stack_trace, crashed_version, cpm):

[mimee, 2016/04/07 23:43:09]

cpm->cpms

[stgao, 2016/04/08 01:14:08]

Done.

+  """Finds culprits for a Chrome crash.
+
+  Args:
+    channel (str): The channel name, could be 'dev', 'canary', 'beta', etc.
+    platform (str): The platform name, could be 'win', 'mac', 'linux',
+                    'android', 'ios', etc.
+    signature (str): The signature of a crash on the Chrome crash server.
+    stack_trace (str): A string containing the stack trace of a crash.
+    crash_version (str): The version of Chrome in which the crash occurred.
+    cpm (dict): Mapping from Chrome version to crash per million page loads.
+
+  Returns:
+    (analysis_result_dict, tag_dict)
+    The analysis result is a dict like below:
+      {
+        "found": True,  # Indicate whether anything is found.
+        "suspected_dep": "src/v8",  # The full path to the dependency.
+        "dep_short_name": "v8",  # A short name to represent the dependency.

[mimee, 2016/04/07 23:43:09]

Why dep_short_name when there is suspected_dep?
Can we keep just one?

[stgao, 2016/04/08 01:14:08]

I'd keep it. It is more for display on UI.
suspected_dep could be quite long (third_party/bla/bla), while dep_short_name is
more concise.

If you are sure that the longer version will be show, we could remove it.

To be consistent with what have for ClusterFuzz, I change dep to project.

[mimee, 2016/04/08 15:36:03]

Would there be a review url, along with revision? I was told that people click
on the review anyway.

[stgao, 2016/04/11 20:32:19]

I guess you mean code review url. Yes, we could do that.
And in Findit for waterfall, actually we show use the code review url if it is
available.

+        "components": ["blink>javascript"],  # Components to file bug against.
+        "culprits": [
+          {
+            "url": "https://chromium.googlesource.com/chromium/.../+/hash",
+            "revision": "commit-hash",
+            "dep_full_path": "src/v8",
+            "dep_short_name": "v8",

[mimee, 2016/04/07 23:43:09]

Why is there a whole set of those under culprit again?

[stgao, 2016/04/08 01:14:08]

This is for individual CL. Culprits won't be always in the same dep.
This is the same as ClusterFuzz.

+            "author": "who@chromium.org",
+            "time": "2015-08-17 03:38:16",  # When the revision was committed.
+            "reason": "A plain string with '\n' as line break to explain why",
+            "confidence": "high/medium/low/0.6",  # Optional confidence score.
+          },
+        ],
+      }
+    The tag dict are allowed key/value pairs to tag the analysis result for
+    query and monitoring purpose on Findit side. For allowed keys, please
+    refer to crash_analysis.py and fracas_crash_analysis.py:
+      For results with normal culprit-finding algorithm:
+        {
+          'found_suspects': True,
+          'has_regression_range': True,
+          'solution': 'core_algorithm',
+        }
+      For results using git blame without a regression range:
+        {
+          'found_suspects': True,
+          'has_regression_range': False,
+          'solution': 'blame',
+        }
+      If nothing is found:
+        {
+          'found_suspects': False,
+        }
+  """
+  # TODO (katesnonia): hook the analysis logic up here.
+  return {'found': False}, {'found_suspects': False}  # pragma: no cover.