Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 1852333002: Always close non-null output stream. (Closed)

Created:
4 years, 8 months ago by Peter Wen
Modified:
4 years, 8 months ago
Reviewers:
gone
CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always close non-null output stream. BUG=595449 Committed: https://crrev.com/17d298aac4611c2838f56c0bce992575eba5c631 Cr-Commit-Position: refs/heads/master@{#384968}

Patch Set 1 #

Patch Set 2 : Surround entire call instead. #

Patch Set 3 : Close stream at caller. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java View 1 2 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Peter Wen
Debated between surrounding the entire method with the try/catch vs adding two additional close() calls ...
4 years, 8 months ago (2016-04-04 17:46:58 UTC) #2
gone
I think the correct thing to do is correct the one place where TabState#saveState() is ...
4 years, 8 months ago (2016-04-04 17:52:23 UTC) #3
Peter Wen
Opps, totally missed that option. Thanks, PTAL. :)
4 years, 8 months ago (2016-04-04 17:59:34 UTC) #4
gone
lgtm, thanks!
4 years, 8 months ago (2016-04-04 18:00:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852333002/40001
4 years, 8 months ago (2016-04-04 18:01:08 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-04 19:02:56 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 19:03:57 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/17d298aac4611c2838f56c0bce992575eba5c631
Cr-Commit-Position: refs/heads/master@{#384968}

Powered by Google App Engine
This is Rietveld 408576698