Removes extra left border from wrench menu buttons

chrome/browser/ui/views/toolbar/wrench_menu.cc

Index: chrome/browser/ui/views/toolbar/wrench_menu.cc
diff --git a/chrome/browser/ui/views/toolbar/wrench_menu.cc b/chrome/browser/ui/views/toolbar/wrench_menu.cc
index a4ce9f54131065945785ea5d49554b64a62a04d9..cffdf70c01c7b8408aed48506f732480eca8a521 100644
--- a/chrome/browser/ui/views/toolbar/wrench_menu.cc
+++ b/chrome/browser/ui/views/toolbar/wrench_menu.cc
@@ -188,16 +188,14 @@ class MenuButtonBackground : public views::Background {
     int w = view->width();
     int h = view->height();
 #if defined(USE_AURA)

[sky, 2014/03/05 15:28:34]

nit: you can remove this ifdef too.

[varkha, 2014/03/05 15:57:38]

Done.

-    // Normal buttons get a border drawn on the right side and the rest gets
-    // filled in. The left button however does not get a line to combine
-    // buttons.
-    int border = 0;
-    if (type_ != RIGHT_BUTTON) {
-      border = 1;
-      canvas->FillRect(gfx::Rect(0, 0, border, h),
-                       BorderColor(view, views::Button::STATE_NORMAL));
-    }
     if (use_new_menu_) {

[sky, 2014/03/05 15:28:34]

view->GetNativeTheme() == ui::NativeThemeAura::instance() was also removed. Does
that need to be added back?

[varkha, 2014/03/05 15:57:38]

Code in
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
is the only place where the menu gets created and with aura it only ever sets
use_new_menu when GetNativeTheme is NativeThemeAura. So this should be OK and
maybe better this way since it removes the need for NativeThemeAura in this file
(I've removed the include as well).

+      // Normal buttons get a border drawn on the right side and the rest gets
+      // filled in. The left button however does not get a line to combine
+      // buttons.
+      if (type_ != RIGHT_BUTTON) {
+        canvas->FillRect(gfx::Rect(0, 0, 1, h),
+                         BorderColor(view, views::Button::STATE_NORMAL));
+      }
       gfx::Rect bounds(view->GetLocalBounds());
       bounds.set_x(view->GetMirroredXForRect(bounds));
       DrawBackground(canvas, view, bounds, state);