Removes extra left border from wrench menu buttons

Removes extra left border from wrench menu buttons. This seems to have been broken in https://codereview.chromium.org/82113004.

BUG=349063
TEST=Visual inspection - see screenshots in the bug. The buttons should have rounded corners.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255266

[varkha, 2014-03-04 22:00:45]

oshima@, could you please take a look? I looked at your change and it appears
that you didn't want to change the look other than in use_new_menu_ case (but
did). Is this true? Thanks.

[oshima, 2014-03-04 22:07:10]

lgtm. thank you for fixing this.

[varkha, 2014-03-04 22:09:02]

The CQ bit was checked by varkha@chromium.org

[commit-bot: I haz the power, 2014-03-04 22:11:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varkha@chromium.org/185233017/1

[commit-bot: I haz the power, 2014-03-05 01:07:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varkha@chromium.org/185233017/1

[commit-bot: I haz the power, 2014-03-05 01:48:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-05 01:48:41]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[varkha, 2014-03-05 01:52:22]

The CQ bit was checked by varkha@chromium.org

[commit-bot: I haz the power, 2014-03-05 02:05:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varkha@chromium.org/185233017/1

[commit-bot: I haz the power, 2014-03-05 02:27:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-05 02:27:55]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[varkha, 2014-03-05 02:39:08]

sky@, could you please take a look for owners review? Thanks.

[sky, 2014-03-05 15:28:33]

https://codereview.chromium.org/185233017/diff/1/chrome/browser/ui/views/tool...
File chrome/browser/ui/views/toolbar/wrench_menu.cc (right):

https://codereview.chromium.org/185233017/diff/1/chrome/browser/ui/views/tool...
chrome/browser/ui/views/toolbar/wrench_menu.cc:190: #if defined(USE_AURA)
nit: you can remove this ifdef too.

https://codereview.chromium.org/185233017/diff/1/chrome/browser/ui/views/tool...
chrome/browser/ui/views/toolbar/wrench_menu.cc:191: if (use_new_menu_) {
view->GetNativeTheme() == ui::NativeThemeAura::instance() was also removed. Does
that need to be added back?

[varkha, 2014-03-05 15:57:38]

Just a question, what are the remaining cases if any, where USE_AURA is _not_
defined in chrome/browser/ui/views?

https://codereview.chromium.org/185233017/diff/1/chrome/browser/ui/views/tool...
File chrome/browser/ui/views/toolbar/wrench_menu.cc (right):

https://codereview.chromium.org/185233017/diff/1/chrome/browser/ui/views/tool...
chrome/browser/ui/views/toolbar/wrench_menu.cc:190: #if defined(USE_AURA)
On 2014/03/05 15:28:34, sky wrote:
> nit: you can remove this ifdef too.

Done.

https://codereview.chromium.org/185233017/diff/1/chrome/browser/ui/views/tool...
chrome/browser/ui/views/toolbar/wrench_menu.cc:191: if (use_new_menu_) {
On 2014/03/05 15:28:34, sky wrote:
> view->GetNativeTheme() == ui::NativeThemeAura::instance() was also removed.
Does
> that need to be added back?

Code in
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
is the only place where the menu gets created and with aura it only ever sets
use_new_menu when GetNativeTheme is NativeThemeAura. So this should be OK and
maybe better this way since it removes the need for NativeThemeAura in this file
(I've removed the include as well).

[sky, 2014-03-05 16:16:19]

On Wed, Mar 5, 2014 at 7:57 AM,  <varkha@chromium.org> wrote:
> Just a question, what are the remaining cases if any, where USE_AURA is
> _not_
> defined in chrome/browser/ui/views?

There are none. That's why I said you can remove the ifdef entirely.
It's always true now.

>
https://codereview.chromium.org/185233017/diff/1/chrome/browser/ui/views/tool...
> File chrome/browser/ui/views/toolbar/wrench_menu.cc (right):
>
>
https://codereview.chromium.org/185233017/diff/1/chrome/browser/ui/views/tool...
> chrome/browser/ui/views/toolbar/wrench_menu.cc:190: #if
> defined(USE_AURA)
> On 2014/03/05 15:28:34, sky wrote:
>>
>> nit: you can remove this ifdef too.
>
>
> Done.
>
>
>
https://codereview.chromium.org/185233017/diff/1/chrome/browser/ui/views/tool...
> chrome/browser/ui/views/toolbar/wrench_menu.cc:191: if (use_new_menu_) {
> On 2014/03/05 15:28:34, sky wrote:
>>
>> view->GetNativeTheme() == ui::NativeThemeAura::instance() was also
>
> removed. Does
>>
>> that need to be added back?
>
>
> Code in
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
> is the only place where the menu gets created and with aura it only ever
> sets use_new_menu when GetNativeTheme is NativeThemeAura. So this should
> be OK and maybe better this way since it removes the need for
> NativeThemeAura in this file (I've removed the include as well).
>
> https://codereview.chromium.org/185233017/

Ah, ok.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sky, 2014-03-05 16:16:48]

LGTM

[varkha, 2014-03-05 16:24:57]

The CQ bit was checked by varkha@chromium.org

[commit-bot: I haz the power, 2014-03-05 16:25:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varkha@chromium.org/185233017/20001

[commit-bot: I haz the power, 2014-03-05 18:03:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-05 18:03:55]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[varkha, 2014-03-05 18:06:32]

The CQ bit was checked by varkha@chromium.org

[commit-bot: I haz the power, 2014-03-05 18:07:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varkha@chromium.org/185233017/20001

[commit-bot: I haz the power, 2014-03-05 20:51:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-05 20:51:31]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[varkha, 2014-03-05 21:21:24]

The CQ bit was checked by varkha@chromium.org

[commit-bot: I haz the power, 2014-03-05 21:21:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varkha@chromium.org/185233017/20001

[commit-bot: I haz the power, 2014-03-06 00:02:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varkha@chromium.org/185233017/20001

[commit-bot: I haz the power, 2014-03-06 02:42:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varkha@chromium.org/185233017/20001

[commit-bot: I haz the power, 2014-03-06 03:12:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varkha@chromium.org/185233017/20001

[commit-bot: I haz the power, 2014-03-06 05:48:24]

Change committed as 255266