Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/incremental-marking.h

Issue 185233008: Consolidate RecordWriteFromCode and RecordWriteForEvacuationFromCode. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/incremental-marking.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 if (FLAG_trace_incremental_marking) { 122 if (FLAG_trace_incremental_marking) {
123 PrintF("[IncrementalMarking] Restarting (new grey objects)\n"); 123 PrintF("[IncrementalMarking] Restarting (new grey objects)\n");
124 } 124 }
125 } 125 }
126 } 126 }
127 127
128 static void RecordWriteFromCode(HeapObject* obj, 128 static void RecordWriteFromCode(HeapObject* obj,
129 Object** slot, 129 Object** slot,
130 Isolate* isolate); 130 Isolate* isolate);
131 131
132 static void RecordWriteForEvacuationFromCode(HeapObject* obj,
133 Object** slot,
134 Isolate* isolate);
135
136 // Record a slot for compaction. Returns false for objects that are 132 // Record a slot for compaction. Returns false for objects that are
137 // guaranteed to be rescanned or not guaranteed to survive. 133 // guaranteed to be rescanned or not guaranteed to survive.
138 // 134 //
139 // No slots in white objects should be recorded, as some slots are typed and 135 // No slots in white objects should be recorded, as some slots are typed and
140 // cannot be interpreted correctly if the underlying object does not survive 136 // cannot be interpreted correctly if the underlying object does not survive
141 // the incremental cycle (stays white). 137 // the incremental cycle (stays white).
142 INLINE(bool BaseRecordWrite(HeapObject* obj, Object** slot, Object* value)); 138 INLINE(bool BaseRecordWrite(HeapObject* obj, Object** slot, Object* value));
143 INLINE(void RecordWrite(HeapObject* obj, Object** slot, Object* value)); 139 INLINE(void RecordWrite(HeapObject* obj, Object** slot, Object* value));
144 INLINE(void RecordWriteIntoCode(HeapObject* obj, 140 INLINE(void RecordWriteIntoCode(HeapObject* obj,
145 RelocInfo* rinfo, 141 RelocInfo* rinfo,
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
279 int no_marking_scope_depth_; 275 int no_marking_scope_depth_;
280 276
281 int unscanned_bytes_of_large_object_; 277 int unscanned_bytes_of_large_object_;
282 278
283 DISALLOW_IMPLICIT_CONSTRUCTORS(IncrementalMarking); 279 DISALLOW_IMPLICIT_CONSTRUCTORS(IncrementalMarking);
284 }; 280 };
285 281
286 } } // namespace v8::internal 282 } } // namespace v8::internal
287 283
288 #endif // V8_INCREMENTAL_MARKING_H_ 284 #endif // V8_INCREMENTAL_MARKING_H_
OLDNEW
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/incremental-marking.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698