Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 185233008: Consolidate RecordWriteFromCode and RecordWriteForEvacuationFromCode. (Closed)

Created:
6 years, 9 months ago by Hannes Payer (out of office)
Modified:
6 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Consolidate RecordWriteFromCode and RecordWriteForEvacuationFromCode. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19639

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -113 lines) Patch
M src/a64/code-stubs-a64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/a64/code-stubs-a64.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/arm/code-stubs-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/code-stubs-arm.cc View 3 chunks +7 lines, -15 lines 0 comments Download
M src/assembler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/assembler.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 chunks +8 lines, -15 lines 0 comments Download
M src/incremental-marking.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/incremental-marking.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/mips/code-stubs-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/code-stubs-mips.cc View 3 chunks +7 lines, -15 lines 0 comments Download
M src/serialize.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/x64/code-stubs-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 3 chunks +7 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Hannes Payer (out of office)
6 years, 9 months ago (2014-03-03 12:30:21 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/185233008/diff/20001/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): https://codereview.chromium.org/185233008/diff/20001/src/ia32/code-stubs-ia32.cc#newcode4725 src/ia32/code-stubs-ia32.cc:4725: nit: Drop the empty newlines, it's cleaner. :)
6 years, 9 months ago (2014-03-03 12:36:42 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/185233008/diff/20001/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): https://codereview.chromium.org/185233008/diff/20001/src/ia32/code-stubs-ia32.cc#newcode4725 src/ia32/code-stubs-ia32.cc:4725: On 2014/03/03 12:36:42, Michael Starzinger wrote: > nit: Drop ...
6 years, 9 months ago (2014-03-03 13:21:32 UTC) #3
Hannes Payer (out of office)
6 years, 9 months ago (2014-03-03 13:28:10 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 manually as r19639 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698