Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1852293002: Make sure to clamp scroll positions when restoring them (Closed)

Created:
4 years, 8 months ago by cbiesinger
Modified:
4 years, 8 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure to clamp scroll positions when restoring them This was an oversight from https://codereview.chromium.org/1846023003 R=leviw@chromium.org BUG=600234 Committed: https://crrev.com/87c6ba998684a8e2f6866e55e8d6ee5229cbde36 Cr-Commit-Position: refs/heads/master@{#384957}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
cbiesinger
4 years, 8 months ago (2016-04-04 15:58:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852293002/1
4 years, 8 months ago (2016-04-04 15:58:45 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-04 17:43:08 UTC) #5
cbiesinger
Emil/Stefan, maybe one of you can review this while Levi is out?
4 years, 8 months ago (2016-04-04 18:13:21 UTC) #7
eae
LGTM
4 years, 8 months ago (2016-04-04 18:14:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852293002/1
4 years, 8 months ago (2016-04-04 18:15:05 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 18:20:41 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 18:22:09 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/87c6ba998684a8e2f6866e55e8d6ee5229cbde36
Cr-Commit-Position: refs/heads/master@{#384957}

Powered by Google App Engine
This is Rietveld 408576698