remoting/host/BUILD.gn - Issue 1852283003: Updating Message Reader and Writer classes to use an interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/BUILD.gn

Issue 1852283003: Updating Message Reader and Writer classes to use an interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/host/BUILD.gn

diff --git a/remoting/host/BUILD.gn b/remoting/host/BUILD.gn

index 6212842e17ea97ee867beca5b5b8ef86074bc021..4d841e36c3e2fb22268a96a1d1a4886409a27019 100644

--- a/remoting/host/BUILD.gn

+++ b/remoting/host/BUILD.gn

@@ -222,6 +222,10 @@ if (is_mac) { # TODO(GYP) Mac build of remoting host.

"security_key/fake_remote_security_key_ipc_client.h",

"security_key/fake_remote_security_key_ipc_server.cc",

"security_key/fake_remote_security_key_ipc_server.h",

+ "security_key/fake_remote_security_key_message_reader.cc",

+ "security_key/fake_remote_security_key_message_reader.h",

+ "security_key/fake_remote_security_key_message_writer.cc",

+ "security_key/fake_remote_security_key_message_writer.h",

"setup/mock_oauth_client.cc",

"setup/mock_oauth_client.h",

]

@@ -293,8 +297,8 @@ if (is_mac) { # TODO(GYP) Mac build of remoting host.

"security_key/gnubby_extension_session_unittest.cc",

"security_key/remote_security_key_ipc_client_unittest.cc",

"security_key/remote_security_key_ipc_server_unittest.cc",

- "security_key/remote_security_key_message_reader_unittest.cc",

- "security_key/remote_security_key_message_writer_unittest.cc",

+ "security_key/remote_security_key_message_reader_impl_unittest.cc",

+ "security_key/remote_security_key_message_writer_impl_unittest.cc",

"server_log_entry_host_unittest.cc",

"setup/me2me_native_messaging_host_unittest.cc",

"setup/oauth_helper_unittest.cc",

« no previous file with comments | « no previous file | remoting/host/security_key/fake_remote_security_key_message_reader.h » ('j') | no next file with comments »