Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 185223002: Remove unused variable in MediaDrmCredentialManager.java (Closed)

Created:
6 years, 9 months ago by Hyungwook Lee
Modified:
6 years, 9 months ago
Reviewers:
Ted C
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://src.chromium.org/chrome/trunk/src/
Visibility:
Public.

Description

Remove unused variable in MediaDrmCredentialManager.java R=tedchoc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255308

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/MediaDrmCredentialManager.java View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Hyungwook Lee
Please review my patches.
6 years, 9 months ago (2014-03-01 05:47:47 UTC) #1
Ted C
https://codereview.chromium.org/185223002/diff/1/content/public/android/java/src/org/chromium/content/browser/MediaDrmCredentialManager.java File content/public/android/java/src/org/chromium/content/browser/MediaDrmCredentialManager.java (right): https://codereview.chromium.org/185223002/diff/1/content/public/android/java/src/org/chromium/content/browser/MediaDrmCredentialManager.java#newcode15 content/public/android/java/src/org/chromium/content/browser/MediaDrmCredentialManager.java:15: private long mNativeMediaDrmCredentialManager; Actually, it doesn't look like this ...
6 years, 9 months ago (2014-03-03 21:34:15 UTC) #2
Hyungwook Lee
On 2014/03/03 21:34:15, Ted C wrote: > https://codereview.chromium.org/185223002/diff/1/content/public/android/java/src/org/chromium/content/browser/MediaDrmCredentialManager.java > File > content/public/android/java/src/org/chromium/content/browser/MediaDrmCredentialManager.java > (right): > ...
6 years, 9 months ago (2014-03-04 02:16:10 UTC) #3
Hyungwook Lee
On 2014/03/04 02:16:10, Hyungwook Lee wrote: > On 2014/03/03 21:34:15, Ted C wrote: > > ...
6 years, 9 months ago (2014-03-04 02:25:00 UTC) #4
Ted C
lgtm
6 years, 9 months ago (2014-03-05 21:39:15 UTC) #5
Ted C
The CQ bit was checked by tedchoc@chromium.org
6 years, 9 months ago (2014-03-05 21:39:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/withlhw@gmail.com/185223002/20001
6 years, 9 months ago (2014-03-05 21:41:17 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 23:10:03 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=275628
6 years, 9 months ago (2014-03-05 23:10:04 UTC) #9
Ted C
The CQ bit was checked by tedchoc@chromium.org
6 years, 9 months ago (2014-03-06 00:51:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/withlhw@gmail.com/185223002/20001
6 years, 9 months ago (2014-03-06 00:51:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/withlhw@gmail.com/185223002/20001
6 years, 9 months ago (2014-03-06 02:52:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/withlhw@gmail.com/185223002/20001
6 years, 9 months ago (2014-03-06 03:17:19 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 10:56:36 UTC) #14
Message was sent while issue was closed.
Change committed as 255308

Powered by Google App Engine
This is Rietveld 408576698