Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18522004: Remove #include "cpu-profiler-inl.h" from v8.h (Closed)

Created:
7 years, 5 months ago by yurys
Modified:
7 years, 5 months ago
Reviewers:
loislo, Yang, Jakob Kummerow
CC:
v8-dev, alph
Visibility:
Public.

Description

Remove #include "cpu-profiler-inl.h" from v8.h This significantly reduces amount of files to be recompiled after changes in cpu-profiler.h and its dependencies. BUG=None R=loislo@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15482

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -12 lines) Patch
M src/api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/regexp-macro-assembler-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/codegen.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/handles.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap-snapshot-generator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/regexp-macro-assembler-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/isolate.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/log.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/log-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/mark-compact.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/optimizing-compiler-thread.h View 1 chunk +1 line, -1 line 0 comments Download
M src/profile-generator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/sampler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/sampler.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/spaces.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/v8.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/regexp-macro-assembler-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
7 years, 5 months ago (2013-07-03 10:31:46 UTC) #1
loislo
lgtm
7 years, 5 months ago (2013-07-03 11:01:03 UTC) #2
Yang
On 2013/07/03 11:01:03, loislo wrote: > lgtm LGTM.
7 years, 5 months ago (2013-07-03 14:29:23 UTC) #3
yurys
7 years, 5 months ago (2013-07-03 15:39:37 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as r15482 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698