Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1852163002: Mojo: Generate Java mojom targets when !cpp_only. (Closed)

Created:
4 years, 8 months ago by Sam McNally
Modified:
4 years, 8 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo: Generate Java mojom targets when !cpp_only. Previously, Java mojom targets were generated unless a variant was specified or typemaps were used. However, Java mojom targets should be generated for the default variant regardless of whether typemaps are used. This cl fixes this by switching on the same variable as all the other decisions for whether to generate Java bindings. BUG=596202 Committed: https://crrev.com/565c598ea3ef433ffb084d88794eea271b2beee8 Cr-Commit-Position: refs/heads/master@{#385324}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/public/tools/bindings/mojom.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Sam McNally
4 years, 8 months ago (2016-04-04 05:20:16 UTC) #3
yzshen1
lgtm
4 years, 8 months ago (2016-04-05 16:20:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852163002/20001
4 years, 8 months ago (2016-04-05 22:49:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 8 months ago (2016-04-05 23:38:03 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 23:39:39 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/565c598ea3ef433ffb084d88794eea271b2beee8
Cr-Commit-Position: refs/heads/master@{#385324}

Powered by Google App Engine
This is Rietveld 408576698