Chromium Code Reviews| Index: tools/debugger/SkDrawCommand.cpp |
| diff --git a/tools/debugger/SkDrawCommand.cpp b/tools/debugger/SkDrawCommand.cpp |
| index d868418d54ba8b4506fbaa05bb38a2f88f6979ec..f8125dfb5a553555794469bde65439ccbcb4aa37 100644 |
| --- a/tools/debugger/SkDrawCommand.cpp |
| +++ b/tools/debugger/SkDrawCommand.cpp |
| @@ -1147,8 +1147,7 @@ static void extract_json_paint_maskfilter(Json::Value& jsonPaint, UrlDataManager |
| Json::Value jsonMaskFilter = jsonPaint[SKDEBUGCANVAS_ATTRIBUTE_MASKFILTER]; |
| SkMaskFilter* maskFilter = (SkMaskFilter*) load_flattenable(jsonMaskFilter, urlDataManager); |
| if (maskFilter != nullptr) { |
| - target->setMaskFilter(maskFilter); |
| - maskFilter->unref(); |
| + target->setMaskFilter(sk_ref_sp(maskFilter)); |
|
f(malita)
2016/04/04 13:46:57
I think this leaks: local ptr already holds a ref
f(malita)
2016/04/04 13:50:15
(maybe refactor as sk_sp<SkMaskFilter> maskFilter(
reed1
2016/04/04 16:34:48
Done.
|
| } |
| } |
| } |
| @@ -1339,7 +1338,7 @@ static void extract_json_paint_blur(Json::Value& jsonPaint, SkPaint* target) { |
| SkASSERT(false); |
| flags = SkBlurMaskFilter::BlurFlags::kNone_BlurFlag; |
| } |
| - target->setMaskFilter(SkBlurMaskFilter::Create(style, sigma, flags)); |
| + target->setMaskFilter(SkBlurMaskFilter::Make(style, sigma, flags)); |
| } |
| } |