Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Unified Diff: components/password_manager/sync/browser/sync_credentials_filter_unittest.cc

Issue 1852093002: components/password_manager: scoped_ptr -> unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and revert an accidental .proto change Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/sync/browser/sync_credentials_filter_unittest.cc
diff --git a/components/password_manager/sync/browser/sync_credentials_filter_unittest.cc b/components/password_manager/sync/browser/sync_credentials_filter_unittest.cc
index a6dbcbabe1f5ce96c6af46194cdd3c6271b427b9..843fde9d5283dce0b81b7e7ced481f850625967d 100644
--- a/components/password_manager/sync/browser/sync_credentials_filter_unittest.cc
+++ b/components/password_manager/sync/browser/sync_credentials_filter_unittest.cc
@@ -138,7 +138,7 @@ TEST_F(CredentialsFilterTest, FilterResults_AllowAll) {
TEST_F(CredentialsFilterTest, FilterResults_DisallowSyncOnReauth) {
// Only 'protect-sync-credential-on-reauth' feature is kept enabled, fill the
// sync credential everywhere but on reauth.
- scoped_ptr<base::FeatureList> feature_list(new base::FeatureList);
+ std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);
std::vector<const base::Feature*> enabled_features;
std::vector<const base::Feature*> disabled_features;
disabled_features.push_back(&features::kProtectSyncCredential);
@@ -184,7 +184,7 @@ TEST_F(CredentialsFilterTest, FilterResults_DisallowSyncOnReauth) {
TEST_F(CredentialsFilterTest, FilterResults_DisallowSync) {
// Both features are kept enabled, should cause sync credential to be
// filtered.
- scoped_ptr<base::FeatureList> feature_list(new base::FeatureList);
+ std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);
std::vector<const base::Feature*> enabled_features;
std::vector<const base::Feature*> disabled_features;
enabled_features.push_back(&features::kProtectSyncCredential);
@@ -262,7 +262,7 @@ TEST_F(CredentialsFilterTest, ShouldSave_SyncCredential_NotSyncingPasswords) {
TEST_F(CredentialsFilterTest, ShouldFilterOneForm) {
// Both features are kept enabled, should cause sync credential to be
// filtered.
- scoped_ptr<base::FeatureList> feature_list(new base::FeatureList);
+ std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);
std::vector<const base::Feature*> enabled_features;
std::vector<const base::Feature*> disabled_features;
enabled_features.push_back(&features::kProtectSyncCredential);
« no previous file with comments | « components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698