components/password_manager/core/common/credential_manager_types_unittest.cc - Issue 1852093002: components/password_manager: scoped_ptr -> unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/common/credential_manager_types_unittest.cc

Issue 1852093002: components/password_manager: scoped_ptr -> unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and revert an accidental .proto change Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/common/credential_manager_types.cc ('k') | components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/common/credential_manager_types_unittest.cc

diff --git a/components/password_manager/core/common/credential_manager_types_unittest.cc b/components/password_manager/core/common/credential_manager_types_unittest.cc

index 75fefb28c38af8fec26c0e5b046be28b7033c91e..46deeb548023463fa1957dc1c5f3f749595576c6 100644

--- a/components/password_manager/core/common/credential_manager_types_unittest.cc

+++ b/components/password_manager/core/common/credential_manager_types_unittest.cc

@@ -28,7 +28,7 @@ class CredentialManagerTypesTest : public testing::Test {

TEST_F(CredentialManagerTypesTest, CreatePasswordFormEmpty) {

CredentialInfo info;

- scoped_ptr<autofill::PasswordForm> form;

+ std::unique_ptr<autofill::PasswordForm> form;

// Empty CredentialInfo -> nullptr.

form = CreatePasswordFormFromCredentialInfo(info, origin_);

@@ -37,7 +37,7 @@ TEST_F(CredentialManagerTypesTest, CreatePasswordFormEmpty) {

TEST_F(CredentialManagerTypesTest, CreatePasswordFormFederation) {

CredentialInfo info;

- scoped_ptr<autofill::PasswordForm> form;

+ std::unique_ptr<autofill::PasswordForm> form;

info.id = base::ASCIIToUTF16("id");

info.name = base::ASCIIToUTF16("name");

@@ -63,7 +63,7 @@ TEST_F(CredentialManagerTypesTest, CreatePasswordFormFederation) {

TEST_F(CredentialManagerTypesTest, CreatePasswordFormLocal) {

CredentialInfo info;

- scoped_ptr<autofill::PasswordForm> form;

+ std::unique_ptr<autofill::PasswordForm> form;

info.id = base::ASCIIToUTF16("id");

info.name = base::ASCIIToUTF16("name");