components/password_manager/core/browser/webdata/password_web_data_service_win.cc - Issue 1852093002: components/password_manager: scoped_ptr -> unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/webdata/password_web_data_service_win.cc

Issue 1852093002: components/password_manager: scoped_ptr -> unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and revert an accidental .proto change Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/webdata/password_web_data_service_win.h ('k') | components/password_manager/core/common/credential_manager_types.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/webdata/password_web_data_service_win.cc

diff --git a/components/password_manager/core/browser/webdata/password_web_data_service_win.cc b/components/password_manager/core/browser/webdata/password_web_data_service_win.cc

index 80b395da06ace3b7fe48aade8538ec4c80b519df..b063667be7acba123db39eea3b7ba674859c7018 100644

--- a/components/password_manager/core/browser/webdata/password_web_data_service_win.cc

+++ b/components/password_manager/core/browser/webdata/password_web_data_service_win.cc

@@ -51,12 +51,12 @@ WebDatabase::State PasswordWebDataService::RemoveIE7LoginImpl(

WebDatabase::COMMIT_NEEDED : WebDatabase::COMMIT_NOT_NEEDED;

}

-scoped_ptr<WDTypedResult> PasswordWebDataService::GetIE7LoginImpl(

+std::unique_ptr<WDTypedResult> PasswordWebDataService::GetIE7LoginImpl(

const IE7PasswordInfo& info,

WebDatabase* db) {

IE7PasswordInfo result;

LoginsTable::FromWebDatabase(db)->GetIE7Login(info, &result);

- return scoped_ptr<WDTypedResult>(

+ return std::unique_ptr<WDTypedResult>(

new WDResult<IE7PasswordInfo>(PASSWORD_IE7_RESULT, result));

}