components/password_manager/core/browser/password_store_factory_util.h - Issue 1852093002: components/password_manager: scoped_ptr -> unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store_factory_util.h

Issue 1852093002: components/password_manager: scoped_ptr -> unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and revert an accidental .proto change Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_store_default_unittest.cc ('k') | components/password_manager/core/browser/password_store_factory_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_store_factory_util.h

diff --git a/components/password_manager/core/browser/password_store_factory_util.h b/components/password_manager/core/browser/password_store_factory_util.h

index 2626618926ba6aae98d43a52f702a4321d87f014..94b9957c1115f3bba9906ae33f4e7ced2043789f 100644

--- a/components/password_manager/core/browser/password_store_factory_util.h

+++ b/components/password_manager/core/browser/password_store_factory_util.h

@@ -5,9 +5,10 @@

#ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_STORE_FACTORY_UTIL_H_

#define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_STORE_FACTORY_UTIL_H_

+#include <memory>

#include "base/files/file_path.h"

#include "base/memory/ref_counted.h"

-#include "base/memory/scoped_ptr.h"

#include "base/single_thread_task_runner.h"

#include "components/keyed_service/core/keyed_service.h"

#include "components/keyed_service/core/service_access_type.h"

@@ -44,7 +45,7 @@ void TrimOrDeleteAffiliationCacheForStoreAndPath(

// Creates a LoginDatabase. Looks in |profile_path| for the database file.

// Does not call LoginDatabase::Init() -- to avoid UI jank, that needs to be

// called by PasswordStore::Init() on the background thread.

-scoped_ptr<LoginDatabase> CreateLoginDatabase(

+std::unique_ptr<LoginDatabase> CreateLoginDatabase(

const base::FilePath& profile_path);

} // namespace password_manager