components/password_manager/core/browser/password_manager_util.h - Issue 1852093002: components/password_manager: scoped_ptr -> unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_util.h

Issue 1852093002: components/password_manager: scoped_ptr -> unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and revert an accidental .proto change Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_manager_unittest.cc ('k') | components/password_manager/core/browser/password_manager_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_util.h

diff --git a/components/password_manager/core/browser/password_manager_util.h b/components/password_manager/core/browser/password_manager_util.h

index a148d6e6c27868495e55d460989ec94a961c2e30..3e7465c109838bfd6ccbe3d440ad9c957ecf22fc 100644

--- a/components/password_manager/core/browser/password_manager_util.h

+++ b/components/password_manager/core/browser/password_manager_util.h

@@ -5,10 +5,10 @@

#ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_UTIL_H_

#define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_UTIL_H_

+#include <memory>

#include <vector>

#include "base/callback.h"

-#include "base/memory/scoped_ptr.h"

#include "base/memory/scoped_vector.h"

#include "components/password_manager/core/browser/password_manager_client.h"

#include "ui/gfx/native_widget_types.h"

@@ -46,7 +46,7 @@ void TrimUsernameOnlyCredentials(

// TODO(crbug.com/555132): Remove this when the migration from ScopedVector is

// finished for PasswordForm.

-std::vector<scoped_ptr<autofill::PasswordForm>> ConvertScopedVector(

+std::vector<std::unique_ptr<autofill::PasswordForm>> ConvertScopedVector(

ScopedVector<autofill::PasswordForm> old_vector);

// A convenience function for testing that |client| has a non-null LogManager