Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: components/password_manager/core/browser/password_autofill_manager_unittest.cc

Issue 1852093002: components/password_manager: scoped_ptr -> unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and revert an accidental .proto change Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_autofill_manager_unittest.cc
diff --git a/components/password_manager/core/browser/password_autofill_manager_unittest.cc b/components/password_manager/core/browser/password_autofill_manager_unittest.cc
index 275aa2ba6e2c671c80bd8b8e670de27095d45062..3e0d9c431d1df27aa4443c39776661465fa1f6f8 100644
--- a/components/password_manager/core/browser/password_autofill_manager_unittest.cc
+++ b/components/password_manager/core/browser/password_autofill_manager_unittest.cc
@@ -107,7 +107,7 @@ class PasswordAutofillManagerTest : public testing::Test {
int fill_data_id() { return fill_data_id_; }
autofill::PasswordFormFillData& fill_data() { return fill_data_; }
- scoped_ptr<PasswordAutofillManager> password_autofill_manager_;
+ std::unique_ptr<PasswordAutofillManager> password_autofill_manager_;
base::string16 test_username_;
base::string16 test_password_;
@@ -122,7 +122,8 @@ class PasswordAutofillManagerTest : public testing::Test {
};
TEST_F(PasswordAutofillManagerTest, FillSuggestion) {
- scoped_ptr<TestPasswordManagerClient> client(new TestPasswordManagerClient);
+ std::unique_ptr<TestPasswordManagerClient> client(
+ new TestPasswordManagerClient);
InitializePasswordAutofillManager(client.get(), nullptr);
EXPECT_CALL(*client->mock_driver(),
@@ -146,7 +147,8 @@ TEST_F(PasswordAutofillManagerTest, FillSuggestion) {
}
TEST_F(PasswordAutofillManagerTest, PreviewSuggestion) {
- scoped_ptr<TestPasswordManagerClient> client(new TestPasswordManagerClient);
+ std::unique_ptr<TestPasswordManagerClient> client(
+ new TestPasswordManagerClient);
InitializePasswordAutofillManager(client.get(), nullptr);
EXPECT_CALL(*client->mock_driver(),
@@ -172,8 +174,9 @@ TEST_F(PasswordAutofillManagerTest, PreviewSuggestion) {
// Test that the popup is marked as visible after recieving password
// suggestions.
TEST_F(PasswordAutofillManagerTest, ExternalDelegatePasswordSuggestions) {
- scoped_ptr<TestPasswordManagerClient> client(new TestPasswordManagerClient);
- scoped_ptr<MockAutofillClient> autofill_client(new MockAutofillClient);
+ std::unique_ptr<TestPasswordManagerClient> client(
+ new TestPasswordManagerClient);
+ std::unique_ptr<MockAutofillClient> autofill_client(new MockAutofillClient);
InitializePasswordAutofillManager(client.get(), autofill_client.get());
gfx::RectF element_bounds;
@@ -208,8 +211,9 @@ TEST_F(PasswordAutofillManagerTest, ExternalDelegatePasswordSuggestions) {
// Test that OnShowPasswordSuggestions correctly matches the given FormFieldData
// to the known PasswordFormFillData, and extracts the right suggestions.
TEST_F(PasswordAutofillManagerTest, ExtractSuggestions) {
- scoped_ptr<TestPasswordManagerClient> client(new TestPasswordManagerClient);
- scoped_ptr<MockAutofillClient> autofill_client(new MockAutofillClient);
+ std::unique_ptr<TestPasswordManagerClient> client(
+ new TestPasswordManagerClient);
+ std::unique_ptr<MockAutofillClient> autofill_client(new MockAutofillClient);
InitializePasswordAutofillManager(client.get(), autofill_client.get());
gfx::RectF element_bounds;
@@ -279,8 +283,9 @@ TEST_F(PasswordAutofillManagerTest, ExtractSuggestions) {
// applications are displayed as the labels of suggestions on the UI (for
// matches of all levels of preferredness).
TEST_F(PasswordAutofillManagerTest, PrettifiedAndroidRealmsAreShownAsLabels) {
- scoped_ptr<TestPasswordManagerClient> client(new TestPasswordManagerClient);
- scoped_ptr<MockAutofillClient> autofill_client(new MockAutofillClient);
+ std::unique_ptr<TestPasswordManagerClient> client(
+ new TestPasswordManagerClient);
+ std::unique_ptr<MockAutofillClient> autofill_client(new MockAutofillClient);
InitializePasswordAutofillManager(client.get(), autofill_client.get());
autofill::PasswordFormFillData data;
@@ -316,8 +321,9 @@ TEST_F(PasswordAutofillManagerTest, PrettifiedAndroidRealmsAreShownAsLabels) {
}
TEST_F(PasswordAutofillManagerTest, FillSuggestionPasswordField) {
- scoped_ptr<TestPasswordManagerClient> client(new TestPasswordManagerClient);
- scoped_ptr<MockAutofillClient> autofill_client(new MockAutofillClient);
+ std::unique_ptr<TestPasswordManagerClient> client(
+ new TestPasswordManagerClient);
+ std::unique_ptr<MockAutofillClient> autofill_client(new MockAutofillClient);
InitializePasswordAutofillManager(client.get(), autofill_client.get());
gfx::RectF element_bounds;
@@ -364,8 +370,9 @@ TEST_F(PasswordAutofillManagerTest, DisplaySuggestionsWithMatchingTokens) {
base::CommandLine::ForCurrentProcess()->AppendSwitch(
autofill::switches::kEnableSuggestionsWithSubstringMatch);
- scoped_ptr<TestPasswordManagerClient> client(new TestPasswordManagerClient);
- scoped_ptr<MockAutofillClient> autofill_client(new MockAutofillClient);
+ std::unique_ptr<TestPasswordManagerClient> client(
+ new TestPasswordManagerClient);
+ std::unique_ptr<MockAutofillClient> autofill_client(new MockAutofillClient);
InitializePasswordAutofillManager(client.get(), autofill_client.get());
gfx::RectF element_bounds;
@@ -408,8 +415,9 @@ TEST_F(PasswordAutofillManagerTest, NoSuggestionForNonPrefixTokenMatch) {
base::CommandLine::ForCurrentProcess()->AppendSwitch(
autofill::switches::kEnableSuggestionsWithSubstringMatch);
- scoped_ptr<TestPasswordManagerClient> client(new TestPasswordManagerClient);
- scoped_ptr<MockAutofillClient> autofill_client(new MockAutofillClient);
+ std::unique_ptr<TestPasswordManagerClient> client(
+ new TestPasswordManagerClient);
+ std::unique_ptr<MockAutofillClient> autofill_client(new MockAutofillClient);
InitializePasswordAutofillManager(client.get(), autofill_client.get());
gfx::RectF element_bounds;
@@ -450,8 +458,9 @@ TEST_F(PasswordAutofillManagerTest,
base::CommandLine::ForCurrentProcess()->AppendSwitch(
autofill::switches::kEnableSuggestionsWithSubstringMatch);
- scoped_ptr<TestPasswordManagerClient> client(new TestPasswordManagerClient);
- scoped_ptr<MockAutofillClient> autofill_client(new MockAutofillClient);
+ std::unique_ptr<TestPasswordManagerClient> client(
+ new TestPasswordManagerClient);
+ std::unique_ptr<MockAutofillClient> autofill_client(new MockAutofillClient);
InitializePasswordAutofillManager(client.get(), autofill_client.get());
gfx::RectF element_bounds;
@@ -496,8 +505,9 @@ TEST_F(PasswordAutofillManagerTest,
base::CommandLine::ForCurrentProcess()->AppendSwitch(
autofill::switches::kEnableSuggestionsWithSubstringMatch);
- scoped_ptr<TestPasswordManagerClient> client(new TestPasswordManagerClient);
- scoped_ptr<MockAutofillClient> autofill_client(new MockAutofillClient);
+ std::unique_ptr<TestPasswordManagerClient> client(
+ new TestPasswordManagerClient);
+ std::unique_ptr<MockAutofillClient> autofill_client(new MockAutofillClient);
InitializePasswordAutofillManager(client.get(), autofill_client.get());
gfx::RectF element_bounds;
@@ -535,8 +545,9 @@ TEST_F(PasswordAutofillManagerTest,
TEST_F(PasswordAutofillManagerTest, PreviewAndFillEmptyUsernameSuggestion) {
// Initialize PasswordAutofillManager with credentials without username.
- scoped_ptr<TestPasswordManagerClient> client(new TestPasswordManagerClient);
- scoped_ptr<MockAutofillClient> autofill_client(new MockAutofillClient);
+ std::unique_ptr<TestPasswordManagerClient> client(
+ new TestPasswordManagerClient);
+ std::unique_ptr<MockAutofillClient> autofill_client(new MockAutofillClient);
fill_data().username_field.value.clear();
InitializePasswordAutofillManager(client.get(), autofill_client.get());

Powered by Google App Engine
This is Rietveld 408576698