components/password_manager/core/browser/log_manager.cc - Issue 1852093002: components/password_manager: scoped_ptr -> unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/log_manager.cc

Issue 1852093002: components/password_manager: scoped_ptr -> unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and revert an accidental .proto change Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/log_manager.h ('k') | components/password_manager/core/browser/log_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/log_manager.cc

diff --git a/components/password_manager/core/browser/log_manager.cc b/components/password_manager/core/browser/log_manager.cc

index 8f78eee4839d9d7dfa09849d68107829ffa37702..17dd339bb54b465bb3d8121e7545240e32ac4507 100644

--- a/components/password_manager/core/browser/log_manager.cc

+++ b/components/password_manager/core/browser/log_manager.cc

@@ -5,6 +5,7 @@

#include "components/password_manager/core/browser/log_manager.h"

#include "base/macros.h"

+#include "base/memory/ptr_util.h"

#include "components/password_manager/core/browser/log_router.h"

namespace password_manager {

@@ -86,9 +87,11 @@ bool LogManagerImpl::IsLoggingActive() const {

} // namespace

// static

-scoped_ptr<LogManager> LogManager::Create(LogRouter* log_router,

- base::Closure notification_callback) {

- return make_scoped_ptr(new LogManagerImpl(log_router, notification_callback));

+std::unique_ptr<LogManager> LogManager::Create(

+ LogRouter* log_router,

+ base::Closure notification_callback) {

+ return base::WrapUnique(

+ new LogManagerImpl(log_router, notification_callback));

}

} // namespace password_manager