components/password_manager/core/browser/credential_manager_pending_request_task.cc - Issue 1852093002: components/password_manager: scoped_ptr -> unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/credential_manager_pending_request_task.cc

Issue 1852093002: components/password_manager: scoped_ptr -> unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and revert an accidental .proto change Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/affiliation_service_unittest.cc ('k') | components/password_manager/core/browser/facet_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/credential_manager_pending_request_task.cc

diff --git a/components/password_manager/core/browser/credential_manager_pending_request_task.cc b/components/password_manager/core/browser/credential_manager_pending_request_task.cc

index 4145b18d67fe262bdaa40108954a6dfa0ad053e4..1e1b6cdbd40f2bbb4db820f9ec42acda2eaaac5b 100644

--- a/components/password_manager/core/browser/credential_manager_pending_request_task.cc

+++ b/components/password_manager/core/browser/credential_manager_pending_request_task.cc

@@ -116,7 +116,7 @@ void CredentialManagerPendingRequestTask::OnGetPasswordStoreResults(

// Otherwise, return an empty credential if we're in zero-click-only mode

// or if the user chooses not to return a credential, and the credential the

// user chooses if they pick one.

- scoped_ptr<autofill::PasswordForm> potential_autosignin_form(

+ std::unique_ptr<autofill::PasswordForm> potential_autosignin_form(

new autofill::PasswordForm(*local_results[0]));

if (zero_click_only_ ||

!delegate_->client()->PromptUserToChooseCredentials(