components/password_manager/content/browser/credential_manager_dispatcher.cc - Issue 1852093002: components/password_manager: scoped_ptr -> unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/credential_manager_dispatcher.cc

Issue 1852093002: components/password_manager: scoped_ptr -> unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and revert an accidental .proto change Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/browser/credential_manager_dispatcher.h ('k') | components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/credential_manager_dispatcher.cc

diff --git a/components/password_manager/content/browser/credential_manager_dispatcher.cc b/components/password_manager/content/browser/credential_manager_dispatcher.cc

index 81194cb8b27a5f1b62b01bed8be95c436f995eb1..653131249e8934b2a725ebf45850f853489e9cf1 100644

--- a/components/password_manager/content/browser/credential_manager_dispatcher.cc

+++ b/components/password_manager/content/browser/credential_manager_dispatcher.cc

@@ -64,8 +64,9 @@ void CredentialManagerDispatcher::OnStore(

if (!client_->IsSavingAndFillingEnabledForCurrentPage())

return;

- scoped_ptr<autofill::PasswordForm> form(CreatePasswordFormFromCredentialInfo(

- credential, web_contents()->GetLastCommittedURL().GetOrigin()));

+ std::unique_ptr<autofill::PasswordForm> form(

+ CreatePasswordFormFromCredentialInfo(

+ credential, web_contents()->GetLastCommittedURL().GetOrigin()));

form->skip_zero_click = !IsZeroClickAllowed();

form_manager_.reset(new CredentialManagerPasswordFormManager(